Mike feature/awscompatible #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added dynamo support, fixed list out of index bug if no events are in a month. Added uuid to the data objects.
ShadowSeals is now writing to Dynamo. Added UUID to shadowseals.
Changed ofa Found link to Event. Made more sense for other scrapers which did not share a unique URL. Added proper logging for SS
Location was missing from both OFA and ShadowSeals
Log file reqiured to write to package a log to write to cloudwatch.
Same as previous commit except for OFA.
for proper naming convetions
MikeJLeon
requested review from
mrvirus9898,
kyrrahnork,
TyReed12,
daonguyen81 and
rberry206
|
To Test - Requires a AWS credential in your environmental variables which are applicable for our class AWS. This is for dynamo. If dynamo is inactive then it should simply create a log file. To Test ON AWS - go to our lambda functions |
daonguyen81
approved these changes
Mar 6, 2019
TyReed12
approved these changes
Mar 6, 2019
|
I ran the test again several times and I found an error in the OFA scraper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests contains the OFAScraper and SSScraper as it appears on the EC2. code writes to dynamo and prints to a log file which is uploaded to cloudwatch if it appears on the EC2.