Calculate recovery_value instead of using a setting #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvz
force-pushed
the
remove-recovery-value-setting
branch
from
51a6b62
to
87293f6
Compare
The recovery_value setting was introduced for use with non-null booleans, but since there's only one sensible option for that case there is no point in making it a setting.
mvz
force-pushed
the
remove-recovery-value-setting
branch
from
87293f6
to
5859fa2
Compare
mvz
force-pushed
the
remove-recovery-value-setting
branch
from
5859fa2
to
31291eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
recovery_valuesetting was introduced in #60 for use with non-null booleans, but since there's only one sensible option for that case there is no point in making it a setting.Final removal of this setting as a breaking change in a way, although this setting was never documented. Therefore, using this setting will still work for now and give a deprecation warning.
Closes #72.