Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow set custom value on recover #60

Merged
merged 1 commit into from
Mar 19, 2017
Merged

Conversation

Wolfer
Copy link

@Wolfer Wolfer commented Oct 31, 2016

When paranoid column set as NOT NULL, recovery fail with error(e.g. "Mysql2::Error: Column 'is_del' cannot be null" ).
This PR allow set custom value with option "recovery_value" for acts_as_paranoid

@rob-murray
Copy link

rob-murray commented Jan 3, 2017

If the column_type is boolean maybe the recovery_value should be set to false by default too? Or a method similar to delete_now_value for default values.

@Wolfer
Copy link
Author

Wolfer commented Jan 5, 2017

Not all need the recovery_value set as false for boolean type. I tried to minimum change the default behavior of gem.

@zzak zzak merged commit 0c74a75 into ActsAsParanoid:master Mar 19, 2017
@zzak zzak modified the milestone: 1.0.0 Mar 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants