ActiveRecord queries with includes now respect :with_deleted => true

[pelargir]

This fixes issue #17 by ensuring :with_deleted => true is respected when using #includes and #joins in association queries. Hat tip to @tkupari for the original fix in goncalossilva/acts_as_paranoid#115

[zzak]

@pelargir The build failed, could you look into it?

[pelargir]

@zzak There.

[alexggordon]

@zzak @pelargir what's the status on this? Can we get this merged?

[pelargir]

@alexggordon still ready to be merged as far as I'm concerned.

[vellotis]

Works great! Regards @pelargir

@zzak I know this project isn't actively used any more. But this PR gives a great improvement. Could you please at least merge it? Publishing a gem would also be welcome.

[zzak]

@vellotis Thanks for the feedback!

I'm hoping to get around to this soon, sorry for such a long delay~

[vellotis]

@zzak Great to hear!

[zzak]

Needs a rebase

[zzak]

@pelargir Thank you!!

@vellotis Merged!

Thanks everyone for your patience <3

[vellotis]

My best regards! @zzak

[btrscott]

Doesn't seem to be working for me. Still including the: AND driver.deleted_at IS NULL in the sql that filters out the records when the associated field is deleted

Using
belongs_to :driver, with_deleted: true

Want to bring up the parent record even though the driver is deleted.

Can anyone confirm the fix works for them? Using 0.5.0 gem.

[btrscott]

@zzak This does not seem to be working for me still. Are you sure this is fixed?

[lordplagus02]

This doesn't actually seem to be fixed, have tried many combinations of scopes and with_deleted. Also does not allow you to do something like belongs_to :model, through: :parent_model, with_deleted: true