Fix flaky variant_override spec #5737
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt-Yorkley
force-pushed
the
flaky-spec-variant-overrides
branch
2 times, most recently
from
e3fbec1
to
6e7d2f0
Compare
It looks like #preload doesn't work nicely on associated objects with the acts_as_paranoid gem, but #includes might work better?
Matt-Yorkley
force-pushed
the
flaky-spec-variant-overrides
branch
from
6e7d2f0
to
b8473ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #5735
It looks like
#preloadon associated objects doesn't apply the soft-deleted scopes nicely, but#includesmight work better.Reference: ActsAsParanoid/acts_as_paranoid#37
What should we test?
Less flaky build...
Release notes
Improved flaky variant_override spec