Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filters in disabled groups being updated #2581

Closed
zzebrum opened this issue Feb 22, 2019 · 3 comments
Closed

Filters in disabled groups being updated #2581

zzebrum opened this issue Feb 22, 2019 · 3 comments
Assignees
@nkartyshov
Labels
Bug P4: Low
Milestone
3.0

Comments

@zzebrum
Copy link
Contributor

zzebrum commented Feb 22, 2019

Steps to reproduce

  1. enable base filter
  2. disable ad blocking filter group
  3. check for update

Expected behavior

base filter is not updated
@zzebrum zzebrum added this to the 3.0 milestone Feb 22, 2019
@nkartyshov
Copy link
Contributor

fixed

@TheHasagi
Copy link
Contributor

The text should be changed like "Nothing to update" \ "No updates found for enabled filters".

img
img

@nkartyshov
Copy link
Contributor

@TheHasagi This will fix in #2609

@zzebrum zzebrum closed this as completed Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkartyshov nkartyshov

Labels
Bug P4: Low
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
3 participants
@nkartyshov @TheHasagi @zzebrum