New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advanced pref.dns.blocking.nxdomain should work consistently #2847
Comments
@admitrevskiy also due to #2851, I suppose that we should keep NXDOMAIN set to true by default. So the task is:
|
@ameshkov, @admitrevskiy: I think the new pref options are virtually perfect, but I've a question re: the wording: if I leave |
@TPS hi! |
Done. Testing instructions for QA:
|
@admitrevskiy I think there needs to be (for those few folks who use such) a way to generally use |
Originally posted & quoting from #2798 (comment) onwards:
Another glitch: When using a
hosts
subscription for DNS-block,pref.dns.blocking.nxdomain
(tried because of discussion in #1582) seems to be ineffective for domains set to ::, 127.0.0.1, or 0.0.0.0 — those don't get NXDOMAIN response per AG log.That makes sense when using
hosts
as originally intended, but adblockers don't do that. I suppose if y'all want to support the former (as rare as that might be), that'd be fine, but isn't the major use by AG purely adblock? Then wouldn't it make sense to be consistent in the DNS-based blocking behavior, especially for an advanced toggle which (currently) isn't the default behavior?The text was updated successfully, but these errors were encountered: