Add userscripts support to Android version

[ameshkov]

• Extensions settings UI (check how it looks like in Win version)
• Adding/updating userscripts

[TPS]

Just to confirm, this will be userscripts subscription, not just static userscripts, right? Or both, just like user filters will be implemented?

[ameshkov]

No, filter subscription is different thing, it will be covered in version 2.3.

[TPS]

Nono, I mean, like the filter subscriptions that will be covered in v2.3, I'm hoping the userscripts' enhancement will include userscripts subscriptions as well, not just static userscripts.

[ameshkov]

Ah, got it. Yeah, there will be a possibility to add custom userscripts by url, not just use some pre-defined.

[Nick-White]

+1 I hope you will be able to specify custom userscripts from files too (not just public URLs) because I have tons of them.

[ameshkov]

@Nick-White of course you will:)

[Bluscream]

I totally second this, would ♥ to see it soon :)

[Bluscream]

How far are we away from the 4.0? :'(

[ameshkov]

Pretty far:(

Btw, which exact userscripts do you want to have in Android?

[Bluscream]

Mostly AAK and ads.fly bypasser and some other stuff like Github Dark Script and other userscript versions of userstyles to save my eyes when browsing the web from my tablet in my bed.

[ameshkov]

AAK looks abandoned, though.

[Bluscream]

It doesn't to me. Whenever i wrote a issue it was resolved within 3-4 days :)

[TPS]

@Bluscream I think that @ameshkov means that last commit was July 6, 2016. Even so, @ameshkov, this is fundamental for AAK's functionality.

Hey, @reek, are you still with us? 😟

[TPS]

@ameshkov @Bluscream @Reek's back, so this is as important as ever. 😃

[ameshkov]

This is good news, thank you!:)

[TPS]

2 more relatively popular projects that need this are https://github.com/adsbypasser/adsbypasser & https://github.com/handyuserscripts/antiadware.

[reek]

Hi guys

I'm back :-)

[TPS]

Welcome back, friend! ☺

[Bluscream]

@ameshkov give this poor guy a beta license reek/anti-adblock-killer#1883 (comment) xP

[TPS]

@ameshkov I agree w/ @Bluscream: @reek, as a maintainer of a (rather important ;) builtin list needs full access to wherever his list might be used, so ß license might useful to him across the platforms… unless @AdguardTeam would like to try to fix/workaround in-house. 😓

[Bluscream]

Any news on this?

[TPS]

@jspenguin2017 Will filterset remain publicly accessible, @ least?

[jspenguin2017]

@TPS Everything will stay open source and publicly accessible, there is no worries about that 😄

[TPS]

Unrelated to AdBlockProtector, https://greasyfork.org/en/scripts/19993-ru-adlist-js-fixes/code (from gorhill/uBlock#2609 (comment)) seems like a fascinating thing to try, as well.

[TPS]

Just a thought: Shouldn't this also allow us to do URL conversions of other types, e.g., http://www.Amazon.com/ → https://smile.Amazon.com/ or more advanced sorcery à la HTTPS Everywhere?

@ameshkov Could #%#(function be used to effect this? Are there any docs about it &/or is this just straight (unsafe⁉️) JS?

[trmdi]

Hi, any good news about this very cool feature?

[Bluscream]

Nothing so far sadly, but the UI rehaul had priority.

[ameshkov]

@ameshkov Could #%#(function be used to effect this? Are there any docs about it &/or is this just straight (unsafe⁉️) JS?

It is straight JS and that's why we limit those rules to AG filters only and not accept them from any third-party filters.

[ameshkov]

Hi, any good news about this very cool feature?

Good news is that we're in process of transition to the single cross-platform filtering engine (codename CoreLibs). AG for Android v2.10 is already partly transitioned, but there's a lot more to do. Once we finish with all the products transition, they will share common functionality.

Regarding the userscripts support, it's not enough to just execute a JS script as script hosts provide an API.

Off-topic: it becomes even more complicated given the changes in userscripts API brought by Greasemonkey 4: https://www.greasespot.net/2017/09/greasemonkey-4-for-script-authors.html
Basically, he decided to implement completely new API that is not backwards-compatible.

[TPS]

@ameshkov Still, #%#(function gives us a little something to play with in the user filters while waiting.

Any1 want to join me experimenting? The example I link to above is a rough-&-dirty implementation of #1436. It exhibits some JS injection to potentially block reading a hardware sensor. 🙇

The simplest userscript I'd like is the www.Amazon.com → smile.Amazon.com conversion, but, looking through the source of several addons/extensions, they involve window.location, tab.url, or chrome.webrequest. Whaddy'all think? Could these be converted successfully?

[ameshkov]

They're mostly Chrome extensions and not userscripts so direct conversion's not possible :(

[TPS]

Ok, how about all these? They mostly use window.location.* & location.href.*. Some of these could possibly be converted? Would any of these rewrite any initial requests before loading a Non-Smile www.Amazon page?

[ameshkov]

@TPS something like that for instance?

amazon.com#%#if(window.location.host === 'amazon.com' || window.location.host === 'www.amazon.com') { window.location.host = 'smile.amazon.com'; }

Don't forget to enable HTTPS filtering on amazon.com

[Bluscream]

There needs to be a better way to find something here than scrolling and scrolling and scrolling

[ministr91]

какие новости?

[byaka]

yep, any news about this?

[vozersky]

we might think about it after we finish Core Libs integration for all the platforms

[byaka]

looks like you thinked and denied? maybe any comments?

[vbagirov]

@byaka the latest AdGuard for Android beta already supports custom userscripts, soon enough it'll be added to release version.

[byaka]

@vbagirov ah, awesome, thx!

[driversti]

Guys, I'm so happy to get the version 3.2 this morning! This feature made my day! Thanks a lot to all of you ❤️