Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
uBlock Origin for Google Chrome and apiBreaker #2609
uBlock Origin 1.12.4
Description of what is happening on that page.
The site uses a MutationObserver to detect changes to the
This is not an issue on Firefox because it supports user styles, there is no need for uBO to modify the
I did observe that I could improve uBO's mutation listener code by using a Set() instead of an Array to coalesce the nodes reported in mutation events. When using an array, uBO has to iterate through over a thousand entries, all for the same two nodes, while if using a Set(), there is only two entries to iterate though. However when using a Set(), the page's style wins -- the iframe ends up not being hidden, which means in the end the solution for the not-hidden iframe has to be something else.