Fix #144: Emit warnings for unneeded ignores #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure, this seems cool, even if you consider it just a first step. Thanks. |
|
Nice! I'd expect a test_app emitting warnings with unneeded ignores |
pbrudnick
approved these changes
Sep 13, 2021
elbrujohalcon
deleted the
elbrujohalcon.144.un_require_previous_rule_exclu
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #144: Emit warnings for unneeded ignores.
The output looks like this…
@paulo-ferraz-oliveira let me know if that's enough.
One thing that it does not do is tell you where exactly have you written that spec. It can be either on the actual file (
-hank(…).) orrebar.config.Adding that info is not impossible but a bit cumbersome, so I decided to release the first iteration without that.