Add support for export_all #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
elbrujohalcon
requested changes
May 9, 2023
elbrujohalcon
approved these changes
May 9, 2023
pbrudnick
approved these changes
May 10, 2023
|
The tests need fixing, @kamilwaz … |
elbrujohalcon
approved these changes
May 10, 2023
|
I missed one commit after rebasing. Now tests are all green. |
|
Yeah… The lesson is: you should not rebase ;) |
|
In any case, I'm merging. Thanks for the contribution, @kamilwaz :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #209.