-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time - Emily #42
base: master
Are you sure you want to change the base?
Time - Emily #42
Conversation
HotelSection 1: Major Learning Goals
Section 2: Code Review and Testing Requirements
Section 3: Feature Requirements
Overall FeedbackGreat work overall! Please do review all the feedback here. I hope it's helpful.
Additional FeedbackGreat work overall! You've built your first project with minimal starting code. This represents an incredible milestone in your journey, and you should be proud of yourself! I am particularly impressed by the way that you organized all your classes so thoughtfully. I do see some room for improvement around ensuring all tests pass before submission, if you have the time. Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
|
|
||
private | ||
|
||
def verify_date(stay_begin, stay_end) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool that you made this a separate method!
end | ||
|
||
def overlapping?(first, last) | ||
@stay_begin <= last && first <= @stay_end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These seems to cover every case and I actually can't believe it! I don't think anyone has written something so simple for this before, student or instructor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That said it would make me feel much more confident in this if there were thorough unit test coverage for it. I don't see any.
…rect fork
Assignment Submission: Hotel
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection