Skip to content

Commit

Permalink
Remove __setitem__ from PyRFLX package API
Browse files Browse the repository at this point in the history
ref #783
  • Loading branch information
jklmnn committed Sep 28, 2021
1 parent e832daf commit eb851df
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
3 changes: 0 additions & 3 deletions rflx/pyrflx/package.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@ def set_message(self, key: str, value: MessageValue) -> None:
def __getitem__(self, key: str) -> MessageValue:
return self.new_message(key)

def __setitem__(self, key: str, value: MessageValue) -> None:
self.set_message(key, value)

def __iter__(self) -> Iterator[MessageValue]:
return self.__messages.values().__iter__()

Expand Down
5 changes: 0 additions & 5 deletions tests/unit/pyrflx_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,6 @@ def test_package_iterator(tlv_package: Package) -> None:
assert [m.name for m in tlv_package] == ["Message"]


def test_package_set_item(tlv_package: Package) -> None:
msg = Message("TLV::Msg", [], {})
tlv_package["Msg"] = MessageValue(msg)


def test_pyrflx_iterator(pyrflx_: PyRFLX) -> None:
assert {p.name for p in pyrflx_} == {
"Ethernet",
Expand Down

0 comments on commit eb851df

Please sign in to comment.