Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove private types #1156

Closed
senier opened this issue Aug 25, 2022 · 2 comments · Fixed by #1179
Closed

Remove private types #1156

senier opened this issue Aug 25, 2022 · 2 comments · Fixed by #1179
Assignees
@senier
Labels
generator Related to generator package (SPARK code generation) small Effort of one person-day or less specification Related to specification package (e.g., specification parsing)
Projects
RecordFlux 0.7

Comments

@senier
Copy link
Member

senier commented Aug 25, 2022 •
edited
Loading

The generator currently doesn't support private types (cf. #758). We need to decide whether we want / need private types at all an either implement them in the generator or remove them from the language.
@senier senier created this issue from a note in RecordFlux Future (To do) Aug 25, 2022
@senier senier added generator Related to generator package (SPARK code generation) specification Related to specification package (e.g., specification parsing) architectural decision Discussion of design decision labels Aug 25, 2022
@senier senier mentioned this issue Aug 25, 2022
Closed
@treiher
Copy link
Collaborator

treiher commented Aug 29, 2022

As we don't have a specific use case for private types, I would be in favor of removing them.

@senier
Copy link
Member Author

senier commented Aug 30, 2022

With the introduction of tagged types this is not necessary anymore. We will remove private types.

@senier senier removed the architectural decision Discussion of design decision label Aug 30, 2022
@senier senier removed this from Medium in RecordFlux Future Aug 30, 2022
@senier senier added this to To do in RecordFlux 0.7 via automation Aug 30, 2022
@senier senier added the small Effort of one person-day or less label Aug 30, 2022
@senier senier changed the title Support or abandon private types Remove private types Aug 30, 2022
@senier senier moved this from To do to Review in RecordFlux 0.7 Sep 2, 2022
@senier senier moved this from Review to Implementation in RecordFlux 0.7 Sep 2, 2022
@senier senier self-assigned this Sep 2, 2022
senier added a commit to AdaCore/RecordFlux-parser that referenced this issue Sep 5, 2022
@senier
Remove support for private types
5756a46 
Ref. AdaCore/RecordFlux#1156
senier added a commit that referenced this issue Sep 5, 2022
@senier
Remove private type support
4dff8f3 
Closes #1156
senier added a commit that referenced this issue Sep 5, 2022
@senier
Remove private type support
dccd0d4 
Closes #1156
@senier senier mentioned this issue Sep 5, 2022
Merged
senier added a commit to AdaCore/RecordFlux-parser that referenced this issue Sep 5, 2022
@senier
Remove support for private types
d95f52b 
Ref. AdaCore/RecordFlux#1156
senier added a commit to AdaCore/RecordFlux-parser that referenced this issue Sep 5, 2022
@senier
Remove support for private types
d543fac 
Ref. AdaCore/RecordFlux#1156
senier added a commit to AdaCore/RecordFlux-parser that referenced this issue Sep 6, 2022
@senier
Remove support for private types
3857196 
Ref. AdaCore/RecordFlux#1156
senier added a commit that referenced this issue Sep 6, 2022
@senier
Update RecordFlux-parser to 0.12.0
6144cc2 
Ref. #1156
@senier senier mentioned this issue Sep 6, 2022
Merged
@senier senier moved this from Implementation to Review in RecordFlux 0.7 Sep 6, 2022
senier added a commit that referenced this issue Sep 6, 2022
@senier
Remove private type support
44a44d1 
Closes #1156
senier added a commit that referenced this issue Sep 6, 2022
@senier
Update RecordFlux-parser to 0.12.0
e51fb69 
Ref. #1156
senier added a commit that referenced this issue Sep 6, 2022
@senier
Remove private type support
0c6d59c 
Closes #1156
senier added a commit that referenced this issue Sep 6, 2022
@senier
Remove private type support
c5f65e3 
Closes #1156
senier added a commit that referenced this issue Sep 6, 2022
@senier
Update RecordFlux-parser to 0.12.0
4f63465 
Ref. #1156
RecordFlux 0.7 automation moved this from Review to Done Sep 6, 2022
@treiher treiher mentioned this issue Sep 15, 2022
Closed
adacore-bot pushed a commit that referenced this issue May 15, 2023
@senier @treiher
Remove support for private types
72c0f3d 
Ref. #1156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@senier senier

Labels
generator Related to generator package (SPARK code generation) small Effort of one person-day or less specification Related to specification package (e.g., specification parsing)
Projects
No open projects
RecordFlux 0.7
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 1156: Remove private type support AdaCore/RecordFlux
2 participants
@senier @treiher