Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove model.declaration.TypeDeclaration #1186

Closed
treiher opened this issue Sep 15, 2022 · 0 comments · Fixed by #1248
Closed

Remove model.declaration.TypeDeclaration #1186

treiher opened this issue Sep 15, 2022 · 0 comments · Fixed by #1248
Assignees
@treiher
Labels
model Related to model package (e.g., model verification) refactoring small Effort of one person-day or less

Comments

@treiher
Copy link
Collaborator

treiher commented Sep 15, 2022

After the removal of private types (cf. #1156), there is no further need for model.declaration.TypeDeclaration. Although it is possible to define sessions with type declarations as its parameters in Python (as is done in c5f65e3/tests/unit/model/session_test.py), such sessions are neither supported by the specification parser nor by the code generator.
@treiher treiher added model Related to model package (e.g., model verification) small Effort of one person-day or less refactoring labels Sep 15, 2022
@treiher treiher self-assigned this Nov 4, 2022
treiher added a commit that referenced this issue Nov 4, 2022
@treiher
Remove unused code for type declarations in sessions
8314a99 
Ref. #1186
@treiher treiher mentioned this issue Nov 4, 2022
Merged
treiher added a commit that referenced this issue Nov 4, 2022
@treiher
Remove unused code for type declarations in sessions
d475e5f 
Ref. #1186
treiher added a commit that referenced this issue Nov 7, 2022
@treiher
Remove unused code for type declarations in sessions
9231d91 
Ref. #1186
treiher added a commit that referenced this issue Nov 7, 2022
@treiher
Remove unused code for type declarations in sessions
082b419 
Ref. #1186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@treiher treiher

Labels
model Related to model package (e.g., model verification) refactoring small Effort of one person-day or less
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 1186: Remove unused code for type declarations in sessions AdaCore/RecordFlux
1 participant
@treiher