-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contradiction check too strict #277
Projects
Comments
senier
pushed a commit
that referenced
this issue
Jun 6, 2020
senier
pushed a commit
that referenced
this issue
Jun 6, 2020
senier
pushed a commit
that referenced
this issue
Jun 6, 2020
senier
pushed a commit
that referenced
this issue
Jun 8, 2020
senier
pushed a commit
that referenced
this issue
Jun 24, 2020
The fix for #277 was actually not proper, as any contradiction would be flagged as an error. However, as long as there is at least one non-contradictory path, we cannot treat a field condition as contradictory. This problem occurred in the test, but was not discovered as the test was missing a error.propagate() call after message construction. This was noticed when making Message constructors raise exceptions again in the discussion of #285. Ref. #248
Merged
senier
pushed a commit
that referenced
this issue
Jun 25, 2020
The fix for #277 was actually not proper, as any contradiction would be flagged as an error. However, as long as there is at least one non-contradictory path, we cannot treat a field condition as contradictory. This problem occurred in the test, but was not discovered as the test was missing a error.propagate() call after message construction. This was noticed when making Message constructors raise exceptions again in the discussion of #285. Ref. #248
senier
pushed a commit
that referenced
this issue
Jun 25, 2020
The fix for #277 was actually not proper, as any contradiction would be flagged as an error. However, as long as there is at least one non-contradictory path, we cannot treat a field condition as contradictory. This problem occurred in the test, but was not discovered as the test was missing a error.propagate() call after message construction. This was noticed when making Message constructors raise exceptions again in the discussion of #285. Ref. #248
treiher
pushed a commit
that referenced
this issue
Jul 23, 2020
treiher
pushed a commit
that referenced
this issue
Jul 23, 2020
The fix for #277 was actually not proper, as any contradiction would be flagged as an error. However, as long as there is at least one non-contradictory path, we cannot treat a field condition as contradictory. This problem occurred in the test, but was not discovered as the test was missing a error.propagate() call after message construction. This was noticed when making Message constructors raise exceptions again in the discussion of #285. Ref. #248
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The check for contradicting conditions seems to be too strict. I see no reason why the model shown below should not be accepted.
The text was updated successfully, but these errors were encountered: