Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor error message #248

Closed
7 tasks done
senier opened this issue May 19, 2020 · 2 comments · Fixed by #285
Closed
7 tasks done

Refactor error message #248

senier opened this issue May 19, 2020 · 2 comments · Fixed by #285
Assignees
@senier

Comments

@senier
Copy link
Member

senier commented May 19, 2020 •
edited
Loading

We hardly have any source location in our error messages that could be used by and IDE to point the user to the source of an error.

  • Introduce Location class (file, start line, start column, end line end column)
  • Add location to expression
  • Fill location in parser
  • Introduce base exception
    • has a list of errors
    • error has severity (error, warning, info), message and list of locations
  • Change all raised exceptions to derice from base exception
  • Change CLI to output <file>:<line>:<col> <severity> <message>
  • Review error handling for places to combine messages
@senier senier self-assigned this May 19, 2020
@treiher
Copy link
Collaborator

treiher commented May 19, 2020

It would be nice if not only the first detected error would be reported. Of course not all types of errors allow that (i.e. syntax errors), but in other cases this would increase the usability. I suppose the mechanism for reporting errors (currently exceptions) would have to be changed to achieve that.

@senier
Copy link
Member Author

senier commented May 19, 2020

That's a very good point. We'll probably only be able to continue checking in certain situations. E.g. performing more checks on a model which failed validation already will only produce more spurious errors. OTOH, checking other messages or files after an error in a different message/file could make sense. I'll see what I can do.

@treiher treiher mentioned this issue May 19, 2020
Merged
senier pushed a commit that referenced this issue May 26, 2020
Use ID in parser
e2e3bc0 
Ref. #248
senier pushed a commit that referenced this issue May 26, 2020
Extend error handling
994df21 
Ref. #248
senier pushed a commit that referenced this issue May 26, 2020
Use new error reporting in CLI
ebedfb9 
Ref. #248
senier pushed a commit that referenced this issue May 26, 2020
Use new error reporting for Internal
5de5492 
Ref. #248
senier pushed a commit that referenced this issue May 26, 2020
New error reporting for reserved words
437f690 
Ref. #248
senier pushed a commit that referenced this issue May 26, 2020
Add location to model
a9f2d1d 
Ref. #248
senier pushed a commit that referenced this issue May 26, 2020
New error reporting for conflicting/duplicate entities
621a12b 
Rf. #248
senier pushed a commit that referenced this issue May 26, 2020
New error reporting for invalid package prefix
e398e50 
Ref. #248
senier pushed a commit that referenced this issue May 26, 2020
Make error propagation generic
25f30f4 
Ref. #248
senier pushed a commit that referenced this issue May 26, 2020
New error reporting for package identifier consistency
79f1750 
Ref. #248
senier pushed a commit that referenced this issue May 26, 2020
New error reporting for file name checking
e31b7a7 
Ref. #248
senier pushed a commit that referenced this issue May 26, 2020
New error reporting for parser tests
b784a4f 
Ref. #248
senier pushed a commit that referenced this issue May 26, 2020
Refactor error propagation
f5c8634 
Ref. #248
senier pushed a commit that referenced this issue May 26, 2020
Convert remaining parser tests
a0f3f29 
Ref. #248
senier pushed a commit that referenced this issue May 26, 2020
Remove ParserError class
a7441db 
Ref. #248
senier pushed a commit that referenced this issue May 26, 2020
Remove ParserError class
d000c18 
Ref. #248
senier pushed a commit that referenced this issue May 28, 2020
Convert multiple model tests to new error reporting
5851c55 
Ref. #248
senier pushed a commit that referenced this issue May 28, 2020
New error reporting for cycle and unreachable field
3a12fb8 
Ref. #248
senier pushed a commit that referenced this issue May 28, 2020
Convert all model tests
a3369c3 
Ref. #248
senier pushed a commit that referenced this issue May 28, 2020
Convert all model tests
337d8cd 
Ref. #248
senier pushed a commit that referenced this issue May 30, 2020
Raise internal error for missing fields
cef7074 
Ref. #248
senier pushed a commit that referenced this issue May 30, 2020
New error reporting for proof errors
e12ceac 
Ref. #248
senier pushed a commit that referenced this issue May 30, 2020
New error reporting for verification
0522592 
Ref. #248
senier pushed a commit that referenced this issue May 30, 2020
Remove exceptions
406f8a9 
Ref. #248
treiher pushed a commit that referenced this issue Jul 23, 2020
@treiher
New error reporting for proof errors
154a5ca 
Ref. #248
treiher pushed a commit that referenced this issue Jul 23, 2020
@treiher
New error reporting for verification
a1ba652 
Ref. #248
treiher pushed a commit that referenced this issue Jul 23, 2020
@treiher
Remove exceptions
bb560de 
Ref. #248
treiher pushed a commit that referenced this issue Jul 23, 2020
@treiher
Check package identifier in model instead of parser
4fc3fc1 
Ref. #248
treiher pushed a commit that referenced this issue Jul 23, 2020
@treiher
Extend location tests
9144932 
Ref. #248
treiher pushed a commit that referenced this issue Jul 23, 2020
@treiher
Collect errors of multiple parsing steps
d752a26 
Ref. #248
treiher pushed a commit that referenced this issue Jul 23, 2020
@treiher
Add location to aggregates and relations
207f228 
Ref. #248
treiher pushed a commit that referenced this issue Jul 23, 2020
@treiher
Move aggregate element range check into model
487f889 
Ref. #248
treiher pushed a commit that referenced this issue Jul 23, 2020
@treiher
Move built-in type check out of grammar
2c28188 
Ref. #248
treiher pushed a commit that referenced this issue Jul 23, 2020
@treiher
Improve error propagation
c276747 
Ref. #248
treiher pushed a commit that referenced this issue Jul 23, 2020
@treiher
Propagate duplicate enumeration literal errors
c8f773f 
Ref. #248
treiher pushed a commit that referenced this issue Jul 23, 2020
@treiher
Test more error messages
3a9bf29 
Ref. #248
treiher pushed a commit that referenced this issue Jul 23, 2020
@treiher
Improve error propagation for refinements
16f89d9 
Ref. #248
treiher pushed a commit that referenced this issue Jul 23, 2020
@treiher
Add more type refinement tests
b141fa1 
Ref. #248
treiher pushed a commit that referenced this issue Jul 23, 2020
@treiher
Add more model tests
5949d04 
Ref. #248
treiher pushed a commit that referenced this issue Jul 23, 2020
@treiher
Set duplicate link location to source identifier
45fbfb0 
Ref. #248
treiher pushed a commit that referenced this issue Jul 23, 2020
@treiher
Add more tests
8df7c94 
Ref. #248
treiher pushed a commit that referenced this issue Jul 23, 2020
@treiher
Add unnecessary Always_Valid test
ec4bd9f 
Ref. #248
treiher pushed a commit that referenced this issue Jul 23, 2020
@treiher
Remove FIXME and broad exception handler
f6d6879 
Ref. #248
treiher pushed a commit that referenced this issue Jul 23, 2020
@treiher
Remove unused code
7b58810 
Ref. #248
treiher pushed a commit that referenced this issue Jul 23, 2020
@treiher
Remove special treatment of refinement identifiers
cf8ce00 
When using an invalid package name for a refinement (say "A.B"), then
the expected error is supposed to be something like "A.B is not a valid
package name". For refinements, however, the super class is initialized
with

   package * "__REFINEMENT__"
   f"{flat_name(sdu.full_name)}__{flat_name(pdu.full_name)}__{field.name}__"

which produces some convoluted error message mentioning that long
internal string. Instead of filtering such situations in the super-class,
we now reinitialized the error buffer after initializing the super-class
of Refinement, effectively ignoring errors in the ID() constructor. The
well-formedness of the package identifier is checked separately.

Ref. #248, #285
treiher pushed a commit that referenced this issue Jul 23, 2020
@treiher
Refactor RangeInteger checks
498bb29 
Ref. #285, #248
treiher pushed a commit that referenced this issue Jul 23, 2020
@treiher
Add type/entity name to error messages
7086379 
Ref. #285, #248
treiher pushed a commit that referenced this issue Jul 23, 2020
@treiher
Fix contradiction and field position verification
d09a8e5 
The fix for #277 was actually not proper, as any contradiction would
be flagged as an error. However, as long as there is at least one
non-contradictory path, we cannot treat a field condition as
contradictory.

This problem occurred in the test, but was not discovered as the test
was missing a error.propagate() call after message construction. This
was noticed when making Message constructors raise exceptions again in
the discussion of #285.

Ref. #248
treiher pushed a commit that referenced this issue Jul 23, 2020
@treiher
Propagate errors immediately for Message
d6dfb36 
Ref. #248, #285
treiher pushed a commit that referenced this issue Jul 23, 2020
@treiher
Use 0:0 for BUILTINS locations
b7ac4a3 
Ref. #285, #248
treiher pushed a commit that referenced this issue Jul 23, 2020
@treiher
Remove special proof handling in variables method
9688759 
Ref. #248, #285
treiher pushed a commit that referenced this issue Jul 23, 2020
@treiher
Check builtin types for conflicts with literals
402d09a 
Ref. #248, #285
treiher pushed a commit that referenced this issue Jul 23, 2020
@treiher
Rename component to field
08aaeb2 
Ref. #248, #285
treiher pushed a commit that referenced this issue Jul 23, 2020
@treiher
Fail operation when both IDs have a location
617a628 
Ref. #248, #285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@senier senier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 248 AdaCore/RecordFlux
2 participants
@senier @treiher