Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dedicated exception types for set and parse errors #510

Closed
jklmnn opened this issue Nov 30, 2020 · 0 comments · Fixed by #542
Closed

Use dedicated exception types for set and parse errors #510

jklmnn opened this issue Nov 30, 2020 · 0 comments · Fixed by #542
Assignees
@rssen
Labels
bug pyrflx Related to pyrflx package (Legacy Python API)
Projects
RecordFlux 0.5

Comments

@jklmnn
Copy link
Member

jklmnn commented Nov 30, 2020

Currently PyRFLX uses python exceptions to indicate errors. This breaks the ability to distinguish between errors due to invalid input data and errors in the library. To fix this all exceptions due to invalid input data should throw dedicated exceptions for parsing or setting fields.
@jklmnn jklmnn created this issue from a note in RecordFlux 0.5 (To do) Nov 30, 2020
@jklmnn jklmnn added bug pyrflx Related to pyrflx package (Legacy Python API) labels Nov 30, 2020
rssen added a commit that referenced this issue Jan 4, 2021
@rssen
Add custom exceptions for set and parse errors
c0958ba 
Ref. #510
rssen added a commit that referenced this issue Jan 6, 2021
@rssen
Add custom exceptions for set and parse errors
c3cdd8a 
Ref. #510
@rssen rssen mentioned this issue Jan 7, 2021
Merged
@treiher treiher moved this from To do to Done in RecordFlux 0.5 Jan 7, 2021
rssen added a commit that referenced this issue Jan 12, 2021
@rssen
Add custom exceptions for set and parse errors
cfad049 
Ref. #510
RecordFlux 0.5 automation moved this from Done to Merged Jan 13, 2021
rssen added a commit that referenced this issue Jan 13, 2021
@rssen
Add custom exceptions for set and parse errors
c3d0921 
Ref. #510
@treiher treiher mentioned this issue Aug 4, 2021
Closed
9 tasks
@treiher treiher mentioned this issue Oct 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rssen rssen

Labels
bug pyrflx Related to pyrflx package (Legacy Python API)
Projects
No open projects
RecordFlux 0.5
  
Merged
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 510: Use dedicated exception types for set and parse errors AdaCore/RecordFlux
2 participants
@jklmnn @rssen