Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 510: Use dedicated exception types for set and parse errors #542

Merged
merged 3 commits into from
Jan 13, 2021
Merged

Issue 510: Use dedicated exception types for set and parse errors #542

merged 3 commits into from
Jan 13, 2021

Conversation

rssen
Copy link
Contributor

@rssen rssen commented Jan 7, 2021

Closes #510

@rssen rssen requested a review from treiher January 7, 2021 12:05
@rssen rssen changed the title Issue 510 Issue 510: Use dedicated exception types for set and parse errors Jan 7, 2021
@treiher treiher requested a review from jklmnn January 7, 2021 12:39
treiher
treiher requested changes Jan 7, 2021
View reviewed changes
rflx/pyrflx/typevalue.py Outdated Show resolved Hide resolved
tests/integration/specs_test.py Outdated Show resolved Hide resolved
tests/unit/pyrflx_test.py Outdated Show resolved Hide resolved
tests/unit/pyrflx_test.py Outdated Show resolved Hide resolved
jklmnn
jklmnn previously approved these changes Jan 7, 2021
View reviewed changes
@rssen rssen requested review from treiher and jklmnn January 12, 2021 16:15
@rssen
Copy link
Contributor Author

rssen commented Jan 12, 2021

Rebased to current develop

@treiher treiher marked this pull request as ready for review January 12, 2021 16:18
jklmnn
jklmnn suggested changes Jan 12, 2021
View reviewed changes
rflx/error.py Show resolved Hide resolved
@rssen rssen requested a review from jklmnn January 13, 2021 14:12
@rssen
Copy link
Contributor Author

rssen commented Jan 13, 2021

Squashed commits

@rssen rssen merged commit ae02586 into develop Jan 13, 2021
@rssen rssen deleted the issue_510 branch January 13, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklmnn jklmnn jklmnn approved these changes

@treiher treiher treiher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use dedicated exception types for set and parse errors
3 participants
@rssen @jklmnn @treiher