Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 353: Allow setting empty sequence field #354

Merged
merged 1 commit into from
Jul 19, 2020
Merged

Issue 353: Allow setting empty sequence field #354

merged 1 commit into from
Jul 19, 2020

Conversation

treiher
Copy link
Collaborator

@treiher treiher commented Jul 18, 2020

Closes #353

@treiher treiher requested review from senier and jklmnn July 18, 2020 09:56
@codecov
Copy link

codecov bot commented Jul 18, 2020 •
edited
Loading

Codecov Report

Merging #354 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #354   +/-   ##
========================================
  Coverage    97.95%   97.96%           
========================================
  Files           25       25           
  Lines         4452     4468   +16     
  Branches       745      751    +6     
========================================
+ Hits          4361     4377   +16     
  Misses          54       54           
  Partials        37       37
Impacted Files Coverage Δ
rflx/generator/core.py 98.65% <100.00%> (+<0.01%) ⬆️
rflx/generator/generator.py 98.30% <100.00%> (+0.12%) ⬆️
rflx/model.py 99.74% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a34251...ba610e9. Read the comment docs.

senier
senier previously approved these changes Jul 18, 2020
View reviewed changes
@treiher treiher force-pushed the issue_353 branch 2 times, most recently from a85cf39 to a652916 Compare July 18, 2020 14:07
@treiher treiher requested review from jklmnn and senier July 18, 2020 14:22
jklmnn
jklmnn previously approved these changes Jul 18, 2020
View reviewed changes
@treiher treiher requested a review from jklmnn July 18, 2020 18:02
@treiher treiher merged commit d09fe38 into develop Jul 19, 2020
@treiher treiher deleted the issue_353 branch July 19, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senier senier senier approved these changes

@jklmnn jklmnn jklmnn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting empty sequence field
3 participants
@treiher @senier @jklmnn