Make 'make setup' macOS-compatible. #368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'makefile.conf' uses the sed switch '-s', which is not available on macOS; macOS sed is derived from BSD sed, and (according to https://man.freebsd.org/cgi/man.cgi?sed(1)) FreeBSD sed 13.0 doesn't support -s either. Since the GNU sed -s (--separate) only applies if there are multiple input files, and in each case here there's only one input file, the -s can be removed without penalty. * makefile.conf (SERVER_HTTP2): change -ns to -n. (C_HTTP2): likewise.
|
|
|
I should add, this doesn’t stop the build: it’s just worrying. |
|
This is now merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'makefile.conf' uses the sed switch '-s', which is not available on macOS; macOS sed is derived from BSD sed, and (according to https://man.freebsd.org/cgi/man.cgi?sed(1)) FreeBSD sed 13.0 doesn't support -s either.
Since the GNU sed -s (--separate) only applies if there are multiple input files, and in each case here there's only one input file, the -s can be removed without penalty.
It would be great if this change could be fed though to the alire version (that’d be v23.0.1, I suppose).