Suggested fix for issue #158 #213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the following function names results in Migration Issue warning from Flash Professional: onKeyUp, onKeyPress, onKeyDown, onMouseDown, onMouseUp, onMouseMove AdamAtomic#206 Replaced all occurances of those names with: handleKeyUp, handleKeyPress, etc. (I hope I got them all!)
FlxU.formatArray() would include the first element twice: AdamAtomic#214
Fixes GitHub issue AdamAtomic#171 AdamAtomic#171 In some places, `super.destroy()` was not required. For instance, some classes extended `FlxBasic` which does not have any content in the `destroy()` method. However, just to be safe (and in case that function gets populated at a later date), calling super was added anyway.
…ck and FlxTilemap
…s for negative numbers Fixed FlxU.round() giving incorrect results for negative numbers. AdamAtomic#191
Fix issue AdamAtomic#191 - Fixed FlxU.round() giving incorrect results for negative numbers
fixed AdamAtomic#12, AdamAtomic#220 Incorrect value for moves in FlxText, FlxTileblock and FlxTilemap
Fix issue AdamAtomic#38, AdamAtomic#193 - FlxPreloader.myURL should take a proper URL
Fix issue AdamAtomic#206 - Migration issues if published by Flash IDE
Fix issue AdamAtomic#171 - Added `super.destroy()` to all overridden `destroy()` methods
Also: - Avoided repetitious code (and made it clearer) - Fixed minor typo in ASDoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FlxObject following a path will continue to move even if they run
out of path. ( see Issue #158 )
#158
This fix adds a "StopWhenFinished" option to "FlxObject::followPath",
as well as some minor changes to avoid repetitious code.