chore: fix test warnings

AdaptiveConsulting · Jun 26, 2024 · 0affb65 · 0affb65
1 parent cee11ed
commit 0affb65
Show file tree

Hide file tree

Showing 9 changed files with 189 additions and 196 deletions.
diff --git a/packages/client/package-lock.json b/packages/client/package-lock.json
diff --git a/packages/client/package.json b/packages/client/package.json
@@ -107,8 +107,8 @@
     "@storybook/addon-links": "8.1.7",
     "@storybook/react": "8.1.7",
     "@storybook/react-vite": "8.1.7",
-    "@testing-library/react": "14.0.0",
-    "@testing-library/user-event": "14.4.3",
+    "@testing-library/react": "16.0.0",
+    "@testing-library/user-event": "14.5.2",
     "@types/d3": "7.4.3",
     "@types/eslint": "8.56.10",
     "@types/google.analytics": "^0.0.42",

diff --git a/packages/client/src/client/App/Analytics/ProfitAndLoss/__tests__/LastPosition.test.tsx b/packages/client/src/client/App/Analytics/ProfitAndLoss/__tests__/LastPosition.test.tsx
@@ -56,36 +56,38 @@ const historyMock3: HistoryEntry[] = [
   },
 ]
 
-const renderComponent = () =>
-  render(
-    <TestThemeProvider>
-      <Subscribe source$={lastPosition$} fallback="No data">
-        <LastPosition />
-      </Subscribe>
-    </TestThemeProvider>,
+const renderComponent = async () =>
+  await act(async () =>
+    render(
+      <TestThemeProvider>
+        <Subscribe source$={lastPosition$} fallback="No data">
+          <LastPosition />
+        </Subscribe>
+      </TestThemeProvider>,
+    ),
   )
 
 describe("LastPositions", () => {
   beforeEach(() => {
     analyticsMock.__resetMocks()
   })
 
-  it("should render the initial last position value", () => {
+  it("should render the initial last position value", async () => {
     const historyMock$ = new BehaviorSubject<HistoryEntry[]>(historyMock1)
     analyticsMock.__setHistoryMock(historyMock$)
 
-    renderComponent()
+    await renderComponent()
 
     expect(screen.getAllByTestId("lastPosition")[0].textContent).toBe(
       `-2,713,309`,
     )
   })
 
-  it("should display the updated last position", () => {
+  it("should display the updated last position", async () => {
     const historyMock$ = new BehaviorSubject<HistoryEntry[]>(historyMock1)
     analyticsMock.__setHistoryMock(historyMock$)
 
-    renderComponent()
+    await renderComponent()
 
     expect(screen.getAllByTestId("lastPosition")[0].textContent).toBe(
       `-2,713,309`,
@@ -98,11 +100,11 @@ describe("LastPositions", () => {
     )
   })
 
-  it("should display positive and negative number correctly", () => {
+  it("should display positive and negative number correctly", async () => {
     const historyMock$ = new BehaviorSubject<HistoryEntry[]>(historyMock1)
     analyticsMock.__setHistoryMock(historyMock$)
 
-    renderComponent()
+    await renderComponent()
 
     expect(screen.getAllByTestId("lastPosition")[0].textContent).toBe(
       `-2,713,309`,