Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoftDepend Multiverse-Core #297

Merged
merged 1 commit into from
Feb 2, 2022
Merged

SoftDepend Multiverse-Core #297

merged 1 commit into from
Feb 2, 2022

Conversation

Rothes
Copy link
Contributor

@Rothes Rothes commented Jan 15, 2022

Make sure Prism sets up custom worlds on enabling.

@Bobcat00
Copy link
Contributor

Ah, is that why Prism didn't see 4 of my worlds?

@Rothes
Copy link
Contributor Author

Rothes commented Jan 15, 2022

Ah, is that why Prism didn't see 4 of my worlds?

Yeah I think so, if Prism is loaded before Multiverse-Core loaded in log.

@Rothes
Copy link
Contributor Author

Rothes commented Jan 15, 2022

Also I think we should hook CreateWorld events?

Copy link
Member

@addstar addstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice find, surprised this wasn't in place already 😣

@addstar
Copy link
Member

addstar commented Feb 2, 2022

Also I think we should hook CreateWorld events?

Probably, but this would be more complex and could introduce bigger issues. Not sure it's worth the effort fixing ourselves.

@addstar addstar merged commit 7b6ec22 into AddstarMC:master Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants