Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhcp server in larger networks throws exception #2541

Closed
timo0 opened this issue Jan 11, 2021 · 8 comments
Closed

dhcp server in larger networks throws exception #2541

timo0 opened this issue Jan 11, 2021 · 8 comments
Assignees
Milestone

Comments

@timo0
Copy link

timo0 commented Jan 11, 2021

My network is defined as 10.10.0.1/21.

I've setuped the dhcpd as follows:

Gateway IP: 10.89.0.1
Range of IP addresses: 10.89.6.1 - 10.89.7.254
Subnet mask: 255.255.248.0

This can be saved but if I start the server the following exception occures:

return s, fmt.Errorf("dhcpv4: range end IP should match range start IP")

If I use a "standard" 255.255.255.0 network everithing is fine.

@ameshkov
Copy link
Member

@ainar-g please take a look

@ainar-g
Copy link
Contributor

ainar-g commented Jan 12, 2021

@ameshkov, judging by the current code, we only support ranges within one /24 network, although I couldn't find that explicitly documented anywhere in our docs. All current tests only check that behaviour. Expanding that functionality to arbitrary networks (and doing that properly, too) may take some time.

@ameshkov ameshkov modified the milestones: v0.105.0, v0.106.0 Jan 12, 2021
@ameshkov
Copy link
Member

Let's reassign to v0.106 then

@ameshkov ameshkov changed the title dhcp server in lager networks throws exception dhcp server in larger networks throws exception Mar 3, 2021
adguard pushed a commit that referenced this issue Mar 16, 2021
Updates #2541.

Squashed commit of the following:

commit c812999
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Mar 16 18:10:07 2021 +0300

    agherr: imp docs

commit f43a5f5
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Mar 16 17:35:59 2021 +0300

    all: imp err handling, fix code

commit ed26ad0
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Mar 16 12:24:17 2021 +0300

    dhcpd: fix ip ranges
@ainar-g
Copy link
Contributor

ainar-g commented Mar 16, 2021

Should be fixed on the edge channel as of snapshot 9736123. Can you please check if our solution fixes the issue for you?

The previous snapshot had a couple of bad bugs. Please verify the snapshot 5243399 instead.

adguard pushed a commit that referenced this issue Mar 17, 2021
Updates #2541.
Updates #2834.

Squashed commit of the following:

commit d158018
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Mar 17 14:51:43 2021 +0300

    all: doc changes; imp naming

commit f036b50
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Mar 17 14:09:19 2021 +0300

    dhcpd: fix static leases
@timo0
Copy link
Author

timo0 commented Mar 18, 2021

Maybe you could short describe how to update to a snapshot?

@ainar-g
Copy link
Contributor

ainar-g commented Mar 18, 2021

That depends on how you installed it initially, the OS, and the CPU architecture. Most of the ways are described in our Wiki. The section on “how to update” might be useful to you, except that you need to download the build from a slightly different URL. For example, the address of the latest edge package for a Linux system on an AMD64 CPU is https://static.adguard.com/adguardhome/edge/AdGuardHome_linux_amd64.tar.gz.

(On a side note, we should probably describe the process better on our Wiki. I filed #2841 for that. Thanks!)

@timo0
Copy link
Author

timo0 commented Mar 18, 2021

Thanks, I've now version v0.106.0-a.69+eb9526cc and this works! Thanks!

@ainar-g
Copy link
Contributor

ainar-g commented Mar 18, 2021

Thank you for making sure! If you encounter new problems, please file a new issue.

@ainar-g ainar-g closed this as completed Mar 18, 2021
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Updates AdguardTeam#2541.

Squashed commit of the following:

commit c812999
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Mar 16 18:10:07 2021 +0300

    agherr: imp docs

commit f43a5f5
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Mar 16 17:35:59 2021 +0300

    all: imp err handling, fix code

commit ed26ad0
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Mar 16 12:24:17 2021 +0300

    dhcpd: fix ip ranges
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Updates AdguardTeam#2541.
Updates AdguardTeam#2834.

Squashed commit of the following:

commit d158018
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Mar 17 14:51:43 2021 +0300

    all: doc changes; imp naming

commit f036b50
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Mar 17 14:09:19 2021 +0300

    dhcpd: fix static leases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants