Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better subnet validation, static DHCP leases outside of dynamic IP range #2838

Closed
ainar-g opened this issue Mar 17, 2021 · 0 comments
Closed

Comments

@ainar-g
Copy link
Contributor

ainar-g commented Mar 17, 2021

Before #2541 users could add static DHCP leases both outside of the range for dynamically assigned IP addresses and outside of the subnet address space. Currently, we only allow adding static DHCP within the dynamic IP address range. The original behaviour was almost certainly too lax, but the new one is probably too restrictive. What we should do instead is allowing people to assign a static DHCP lease outside of the dynamic IP range, but only as long as the IP address is still within the subnet.

@ainar-g ainar-g added this to the v0.106.0 milestone Mar 17, 2021
@ainar-g ainar-g self-assigned this Mar 17, 2021
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Closes AdguardTeam#2838.
Updates AdguardTeam#2834.

Squashed commit of the following:

commit 608dce2
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Mar 18 16:49:20 2021 +0300

    dhcpd: fix windows; imp code

commit 5e56eeb
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Mar 17 18:47:54 2021 +0300

    dhcpd: imp static lease validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant