Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DHCP options are erased when the configuration is updated via the HTTP API #2927

Closed
ainar-g opened this issue Apr 6, 2021 · 2 comments
Closed

DHCP options are erased when the configuration is updated via the HTTP API #2927

ainar-g opened this issue Apr 6, 2021 · 2 comments
Assignees
@ainar-g
Labels
bug P2: High
Milestone
v0.106.0

Comments

@ainar-g
Copy link
Contributor

ainar-g commented Apr 6, 2021

@mc9662 in #2842 (comment) has found an issue: any change in the DHCPv4 configuration made over HTTP API erases the DHCP options users set in the configuration file. That obviously shouldn't happen.
@ainar-g ainar-g self-assigned this Apr 6, 2021
@ainar-g ainar-g added this to the v0.106.0 milestone Apr 6, 2021
@ainar-g ainar-g mentioned this issue Apr 6, 2021
Closed
adguard pushed a commit that referenced this issue Apr 6, 2021
@ainar-g
Pull request: dhcpd: do not overwrite dhcpv4 options
65553a2 
Updates #2927.

Squashed commit of the following:

commit b4b0f59
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Apr 6 16:31:01 2021 +0300

    dhcpd: do not overwrite dhcpv4 options
@ainar-g
Copy link
Contributor Author

ainar-g commented Apr 6, 2021

Should be fixed on the edge channel as of snapshot 65553a2. @mc9662, can you please check if our solution fixes the issue for you?

@mc9662
Copy link

mc9662 commented Apr 6, 2021

Yep, looks good, I've tested the :edge docker image and can confirm my DHCPv4 -6 options in AdGuardHome.yaml were maintained after a change to the DHCPv4 settings via the web interface. Expected changes via the settings in the web interface were made to AdGuardHome.yaml

Thank you for the swift fix - appreciated, Matt

@ainar-g ainar-g closed this as completed Apr 6, 2021
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@ainar-g @heyxkhoa
Pull request: dhcpd: do not overwrite dhcpv4 options
431af1b 
Updates AdguardTeam#2927.

Squashed commit of the following:

commit b4b0f59
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Apr 6 16:31:01 2021 +0300

    dhcpd: do not overwrite dhcpv4 options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ainar-g ainar-g

Labels
bug P2: High
Projects
None yet
Milestone
v0.106.0
Development

No branches or pull requests
2 participants
@ainar-g @mc9662