Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspect InitTLSCiphers function #2993

Closed
EugeneOne1 opened this issue Apr 21, 2021 · 1 comment
Closed

Inspect InitTLSCiphers function #2993

EugeneOne1 opened this issue Apr 21, 2021 · 1 comment
Assignees
Milestone

Comments

@EugeneOne1
Copy link
Member

The file internal/home/tls.go contains some unclear logic in the following function:

// InitTLSCiphers performs the same work as initDefaultCipherSuites() from
// crypto/tls/common.go but don't uses lots of other default ciphers.
func InitTLSCiphers() (ciphers []uint16) {

Initially, the function was added during #1384 into the util package which has already been removed.

The documentation for it prompts to follow the crypto/tls/common.go to find initDefaultCipherSuites function, the implementation of which is suspiciously similar. Perhaps, there is a way to use its results directly.

@EugeneOne1 EugeneOne1 added this to the v0.107.0 milestone Apr 21, 2021
@EugeneOne1 EugeneOne1 self-assigned this Apr 21, 2021
@ainar-g ainar-g modified the milestones: v0.107.0, v0.107.1 Dec 13, 2021
@ainar-g ainar-g modified the milestones: v0.107.1, v0.107.2, v0.107.3 Dec 29, 2021
@EugeneOne1 EugeneOne1 changed the title Inspect InitTLSCiphers function Inspect InitTLSCiphers function Jan 19, 2022
@EugeneOne1 EugeneOne1 assigned ainar-g and unassigned EugeneOne1 Jan 19, 2022
@ainar-g
Copy link
Contributor

ainar-g commented Jan 21, 2022

Go 1.17 ignores the order of the cipher suites, so we can probably greatly simplify it in v0.108.

@ainar-g ainar-g modified the milestones: v0.107.3, v0.108.0 Jan 21, 2022
@ainar-g ainar-g modified the milestones: v0.108.0, v0.107.14 Sep 29, 2022
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Closes AdguardTeam#2993.

Squashed commit of the following:

commit 6c521e5
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Jan 25 21:39:48 2022 +0300

    all: imp tls cipher selection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants