Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to disable certain client sources #3020

Closed
ainar-g opened this issue Apr 28, 2021 · 3 comments
Closed

Make it possible to disable certain client sources #3020

ainar-g opened this issue Apr 28, 2021 · 3 comments
Assignees
@EugeneOne1
Labels
feature request P3: Medium
Milestone
v0.107.7

Comments

@ainar-g
Copy link
Contributor

ainar-g commented Apr 28, 2021

Make it possible to disable certain client sources

Clients might want to disable some of our client information enriching functionality, like WHOIS and arp, for various reasons. Here is one example with arp, and I'm pretty sure I remember somebody wanting to disable either rDNS or WHOIS. And in fact, we already have a separate boolean for /etc/hosts parsing.

It could be a setting in a new separate block, like:

'clients':
  'disabled_sources':
  - 'rdns'

@ameshkov, what do you think?
@ainar-g ainar-g mentioned this issue Apr 28, 2021
Closed
@ammnt
Copy link

ammnt commented Apr 28, 2021

Yes! Please add the WHOIS and ARP Request Disable features. Good idea😘

@ainar-g ainar-g mentioned this issue May 24, 2021
Closed
@ameshkov ameshkov added this to the v0.109.0 milestone Jun 1, 2021
@ameshkov
Copy link
Member

ameshkov commented Jun 1, 2021

Yeah, good idea

@ainar-g ainar-g mentioned this issue Sep 13, 2021
Closed
@alexdelprete
Copy link

Was this implemented? I was looking for a way to disable importing /etc/hosts in the config. Didn't find it in the UI. Thanks.

@EugeneOne1 EugeneOne1 mentioned this issue Mar 22, 2022
Closed
3 tasks
@jumpsmm7 jumpsmm7 mentioned this issue Mar 23, 2022
Open
3 tasks
@ainar-g ainar-g modified the milestones: v0.109.0, v0.108.0 Apr 18, 2022
@EugeneOne1 EugeneOne1 mentioned this issue Apr 26, 2022
Closed
@ainar-g ainar-g modified the milestones: v0.108.0, v0.107.7 Jun 2, 2022
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 3020 runtime clients sources control
40ee0d8 
Merge in DNS/adguard-home from 3020-client-sources to master

Closes AdguardTeam#3020.

Squashed commit of the following:

commit f8e6b6d
Merge: 41fb071 0a1ff65
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Mon Apr 25 19:19:15 2022 +0300

    Merge branch 'master' into 3020-client-sources

commit 41fb071
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Apr 25 13:38:28 2022 +0300

    home: fix nil, imp docs

commit aaa7765
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Apr 25 12:25:47 2022 +0300

    home: imp code

commit 3f71b99
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Fri Apr 22 19:12:27 2022 +0300

    home: runtime clients sources control
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
feature request P3: Medium
Projects
None yet
Milestone
v0.107.7
Development

No branches or pull requests
5 participants
@ainar-g @ameshkov @alexdelprete @EugeneOne1 @ammnt