Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WHOIS panics #4525

Closed
EugeneOne1 opened this issue Apr 26, 2022 · 0 comments
Closed

WHOIS panics #4525

EugeneOne1 opened this issue Apr 26, 2022 · 0 comments
Assignees
@EugeneOne1
Labels
bug P2: High
Milestone
v0.107.7

Comments

@EugeneOne1
Copy link
Member

In #3020 we've introduced a feature of controlling certain runtime clients sources. The initialization of WHOIS is now performed with logical error:

AdGuardHome/internal/home/dns.go

Lines 140 to 142 in 235316e

if !config.Clients.Sources.WHOIS {
Context.whois = initWHOIS(&Context.clients)
}

It's initialized when shouldn't and vice versa. Fix ASAP.
@ainar-g ainar-g added this to the v0.107.7 milestone Apr 26, 2022
@ainar-g ainar-g pinned this issue Apr 26, 2022
@ainar-g ainar-g unpinned this issue Apr 26, 2022
adguard pushed a commit that referenced this issue Jun 2, 2022
@EugeneOne1 @ainar-g
cherry-pick: 4525 fix panic
adadd55 
Merge in DNS/adguard-home from 3020-fix-panic to master

Closes #4525.

Squashed commit of the following:

commit f8d9e25
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Apr 26 15:09:11 2022 +0300

    home: imp code

commit 8fe02c8
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Apr 26 14:44:33 2022 +0300

    home: fix panic
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 4525 fix panic
4273a85 
Merge in DNS/adguard-home from 3020-fix-panic to master

Closes AdguardTeam#4525.

Squashed commit of the following:

commit f8d9e25
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Apr 26 15:09:11 2022 +0300

    home: imp code

commit 8fe02c8
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Apr 26 14:44:33 2022 +0300

    home: fix panic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
bug P2: High
Projects
None yet
Milestone
v0.107.7
Development

No branches or pull requests
2 participants
@ainar-g @EugeneOne1