Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$denyallow rules are applied to IP addresses #3175

Closed
ameshkov opened this issue May 24, 2021 · 0 comments
Closed

$denyallow rules are applied to IP addresses #3175

ameshkov opened this issue May 24, 2021 · 0 comments
Assignees
@ameshkov
Labels
bug P2: High
Milestone
v0.107.0

Comments

@ameshkov
Copy link
Member

Here's how it looks like:

image

Original report: #2923 (comment)

We should handle this in the urlfilter -- IP addresses should be handled as a special case.

Temporary solution is to unblock IP addresses:
@@/^[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}$/
@ameshkov ameshkov added this to the v0.107.0 milestone May 24, 2021
@ameshkov ameshkov self-assigned this May 24, 2021
@ameshkov ameshkov mentioned this issue May 24, 2021
Closed
adguard pushed a commit to AdguardTeam/urlfilter that referenced this issue Dec 14, 2021
@ameshkov
Pull request: do not apply denyallow to IP addresses
473852c 
Merge in DNS/urlfilter from denyallowips to master

Related to AdguardTeam/AdGuardHome#3175

Squashed commit of the following:

commit adb8306
Author: Andrey Meshkov <am@adguard.com>
Date:   Tue Dec 14 17:41:40 2021 +0300

    fix golangci-lint

commit becb0d7
Author: Andrey Meshkov <am@adguard.com>
Date:   Tue Dec 14 17:37:44 2021 +0300

    fix review issues

commit 028d7f8
Author: Andrey Meshkov <am@adguard.com>
Date:   Tue Dec 14 17:28:46 2021 +0300

    added bench, fixed specs

commit 13a71a8
Author: Andrey Meshkov <am@adguard.com>
Date:   Tue Dec 14 17:14:12 2021 +0300

    do not apply denyallow to IP addresses
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@ainar-g @heyxkhoa
Pull request: all: do not apply $denyallow to ip addrs
40df011 
Closes AdguardTeam#3175.

Squashed commit of the following:

commit e80e461
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Dec 14 18:03:26 2021 +0300

    all: imp docs

commit 3c73a72
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Dec 14 17:57:01 2021 +0300

    all: do not apply $denyallow to ip addrs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ameshkov ameshkov

Labels
bug P2: High
Projects
None yet
Milestone
v0.107.0
Development

No branches or pull requests
1 participant
@ameshkov