Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNAMEs not made lowercase before matching #3335

Closed
sjhgvr opened this issue Jul 11, 2021 · 2 comments
Closed

CNAMEs not made lowercase before matching #3335

sjhgvr opened this issue Jul 11, 2021 · 2 comments
Assignees
@ainar-g
Labels
bug P2: High
Milestone
v0.107.0

Comments

@sjhgvr
Copy link

sjhgvr commented Jul 11, 2021 •
edited
Loading

Using oisd abp full on v0.106.3

Visiting filterlist.com (yes without the s) (CNAME HDRedirect-LB7-5a03e1c2772e1c9c.elb.us-east-1.amazonaws.com) is allowed
Visiting HDRedirect-LB7-5a03e1c2772e1c9c.elb.us-east-1.amazonaws.com is blocked
Visiting hdredirect-lb7-5a03e1c2772e1c9c.elb.us-east-1.amazonaws.com is blocked

Since lowercase "hdredirect-lb7-5a03e1c2772e1c9c.elb.us-east-1.amazonaws.com" is present in oisd abp full, I expect filterlist.com to be blocked.

It seems after domain lookup CNAMEs are not made lowercase before matching.
@ainar-g ainar-g self-assigned this Jul 12, 2021
@ainar-g ainar-g added this to the v0.107.0 milestone Jul 12, 2021
adguard pushed a commit that referenced this issue Jul 12, 2021
@ainar-g
Pull request: filtering: fix letter case in cname matching
f419896 
Updates #3335.

Squashed commit of the following:

commit ff55c11
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Mon Jul 12 12:38:46 2021 +0300

    filtering: fix letter case in cname matching
@ainar-g
Copy link
Contributor

ainar-g commented Jul 12, 2021

Thank you for your report! That should be fixed as of snapshot f419896 on the edge channel. Could you please check if the solution works for you?

@ainar-g ainar-g mentioned this issue Jul 13, 2021
Closed
@ainar-g
Copy link
Contributor

ainar-g commented Jul 26, 2021

I'll close this issue for now. Please feel free to reopen with more details if you think that something should be fixed.

@ainar-g ainar-g closed this as completed Jul 26, 2021
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@ainar-g @heyxkhoa
Pull request: filtering: fix letter case in cname matching
ced1642 
Updates AdguardTeam#3335.

Squashed commit of the following:

commit ff55c11
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Mon Jul 12 12:38:46 2021 +0300

    filtering: fix letter case in cname matching
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ainar-g ainar-g

Labels
bug P2: High
Projects
None yet
Milestone
v0.107.0
Development

No branches or pull requests
2 participants
@ainar-g @sjhgvr