Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite ist case-sensitiv #3351

Closed
DannySotzny opened this issue Jul 13, 2021 · 5 comments
Closed

Rewrite ist case-sensitiv #3351

DannySotzny opened this issue Jul 13, 2021 · 5 comments
Assignees
Milestone

Comments

@DannySotzny
Copy link

At Filter -> DNS Rewrite it is possible to use case sensitiv hostnames. AdGuard accept "test.abc.org" And "Test.abc.org" at the Same Time. But only processes the lower case!

Prerequisites

  • [ X ] I am running the latest version
  • [ X ] I checked the documentation and found no answer
  • [ X ] I checked to make sure that this issue has not already been filed

Issue Details

I create a Rewrite for Test.abc.org and test.abc.org. One to 1.1.1.1 and the second to 2.2.2.2
When both are created, the IP is output from the lower case one.
If only the entry with the capital letter exists, nothing will be found.

Expected Behavior

The UI should transform any Host to lower-case.

Actual Behavior

it accept any spelling but responds only to the lower case variant

Screenshots

Both are created:

image

Only the false is created

image

Additional Information

@ainar-g
Copy link
Contributor

ainar-g commented Jul 13, 2021

This could be a dup of #3335, which is fixed on the edge channel. Can you please look if the fix for that issue also fixes yours?

@ainar-g ainar-g added the waiting for data Waiting for users to provide more data. label Jul 13, 2021
@DannySotzny
Copy link
Author

This could be a dup of #3335, which is fixed on the edge channel. Can you please look if the fix for that issue also fixes yours?

With the current EDGE version, which was uploaded to the Docker Hub an hour ago, the error persists.
I create a redirect for "Test.abc.de". AdGuard finds nothing. If I then create one for "test.abc.de", it gives a response (previously NXDOMAIN).

@ainar-g
Copy link
Contributor

ainar-g commented Jul 13, 2021

I see, thanks. We'll look into it.

@ainar-g ainar-g added bug needs investigation Needs to be reproduced reliably. P3: Medium and removed waiting for data Waiting for users to provide more data. labels Jul 13, 2021
@ainar-g ainar-g self-assigned this Jul 13, 2021
@ainar-g ainar-g added this to the v0.107.0 milestone Jul 13, 2021
adguard pushed a commit that referenced this issue Jul 13, 2021
Updates #3351.

Squashed commit of the following:

commit cc1c72c
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Jul 13 17:23:33 2021 +0300

    filtering: fix legacy rewrite domain case
@ainar-g
Copy link
Contributor

ainar-g commented Jul 13, 2021

We have added another fix as of revision 1674475 on the edge channel. Could you please check if the issue is now fixed?

@ainar-g ainar-g removed the needs investigation Needs to be reproduced reliably. label Jul 13, 2021
@DannySotzny
Copy link
Author

Ok, now it works correctly. When inserting, the domain is converted to lower case and the error no longer occurs. 👍

heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Updates AdguardTeam#3351.

Squashed commit of the following:

commit cc1c72c
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Jul 13 17:23:33 2021 +0300

    filtering: fix legacy rewrite domain case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants