Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard-Top clients-Requests count-Client does not change timely after disable Anonymize client IP #3890

Closed
3 tasks done
MkQtS opened this issue Nov 27, 2021 · 4 comments
Closed
3 tasks done

Dashboard-Top clients-Requests count-Client does not change timely after disable Anonymize client IP #3890

MkQtS opened this issue Nov 27, 2021 · 4 comments
Assignees
@EugeneOne1
Labels
bug P3: Medium
Milestone
v0.107.0

Comments

@MkQtS
Copy link
Contributor

MkQtS commented Nov 27, 2021

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Issue Details

There are two source DNS request IP in my network. One is 172.16.16.16#127, another is 127.0.0.1#127. When Anonymize client IP is enabled, Dashboard-Top clients-Client shows 127.0.0.0 and 172.16.0.0. Then disable Anonymize client IP and clear query logs and statistics. Dashboard-Top clients-Requests count return to zero, but Client still shows 127.0.0.0 and 172.16.0.0, not 127.0.0.1 and 172.16.16.16. Click it, it turns to http://172.16.16.16:128/#logs?response_status=&search=127.0.0.0 and no result can be shown. Manually search 127.0.0.1, results can be shown.

Restart Adguard Home can solve the problem.

  • Version of AdGuard Home server:
    • v0.107.0-b.15
  • How did you install AdGuard Home:
    • GitHub releases
  • How did you setup DNS configuration:
    • Router
  • If it's a router or IoT, please write device model:
    • x86 computer
  • CPU architecture:
    • AMD64
  • Operating system and version:
    • LuCI openwrt-18.06-k5.4 branch (git-21.322.62925-ea9b160)

Expected Behavior

Disable Anonymize client IP and clear query logs and statistics. Dashboard-Top clients-Requests count-Client shows 127.0.0.1 and 172.16.16.16 immediately.

Actual Behavior

Disable Anonymize client IP and clear query logs and statistics. Dashboard-Top clients-Requests count-Client still shows 127.0.0.0 and 172.16.0.0.
@ainar-g ainar-g added this to the v0.107.0 milestone Nov 29, 2021
@ainar-g
Copy link
Contributor

ainar-g commented Nov 29, 2021

Thank you for the report. The statistics module has an in-memory buffer, and apparently it isn't cleared when the rest of statistics is cleared. We'll try to fix this in the next beta.

adguard pushed a commit that referenced this issue Dec 6, 2021
@EugeneOne1
Pull request: 3890 fix anonymization
d2cf323 
Merge in DNS/adguard-home from 3890-fix-stats to master

Updates #3890.

Squashed commit of the following:

commit a77a620
Merge: 834493a 90e65b6
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Dec 6 17:22:16 2021 +0300

    Merge branch 'master' into 3890-fix-stats

commit 834493a
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Dec 6 17:09:30 2021 +0300

    querylog: load once

commit b8000e7
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Dec 6 16:54:41 2021 +0300

    querylog: fix docs

commit 7db99cc
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Dec 6 16:51:31 2021 +0300

    querylog: imp docs

commit 2a84650
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Dec 6 15:48:09 2021 +0300

    querylog: imp anonyization

commit 0f63feb
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Dec 6 14:44:37 2021 +0300

    all: imp code & docs

commit c4ccdcb
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Dec 6 14:24:30 2021 +0300

    all: log changes

commit 60bb777
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Dec 6 14:08:41 2021 +0300

    all: use atomic value

commit c45886b
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Nov 30 18:50:02 2021 +0300

    all: anonymize separately
@EugeneOne1
Copy link
Member

@MkQtS, the latest build in the edge channel should fix the issue. Could you please install it and check if it does?

Note also that statistics entries which have been written before turning Anonymize client IP on are remaining the same.

@MkQtS
Copy link
Contributor Author

MkQtS commented Dec 11, 2021

@EugeneOne1, Sorry for late response. It's fixed in v0.107.0-a.223+86cffcd1, thank you.

@EugeneOne1
Copy link
Member

@MkQtS, closing the issue for now.

@MkQtS MkQtS closed this as completed Dec 11, 2021
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 3890 fix anonymization
4605c9a 
Merge in DNS/adguard-home from 3890-fix-stats to master

Updates AdguardTeam#3890.

Squashed commit of the following:

commit a77a620
Merge: 834493a 90e65b6
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Dec 6 17:22:16 2021 +0300

    Merge branch 'master' into 3890-fix-stats

commit 834493a
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Dec 6 17:09:30 2021 +0300

    querylog: load once

commit b8000e7
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Dec 6 16:54:41 2021 +0300

    querylog: fix docs

commit 7db99cc
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Dec 6 16:51:31 2021 +0300

    querylog: imp docs

commit 2a84650
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Dec 6 15:48:09 2021 +0300

    querylog: imp anonyization

commit 0f63feb
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Dec 6 14:44:37 2021 +0300

    all: imp code & docs

commit c4ccdcb
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Dec 6 14:24:30 2021 +0300

    all: log changes

commit 60bb777
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Dec 6 14:08:41 2021 +0300

    all: use atomic value

commit c45886b
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Nov 30 18:50:02 2021 +0300

    all: anonymize separately
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
bug P3: Medium
Projects
None yet
Milestone
v0.107.0
Development

No branches or pull requests
3 participants
@ainar-g @EugeneOne1 @MkQtS