Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot rewrite responses to empty NOERROR #4133

Closed
ameshkov opened this issue Jan 14, 2022 · 0 comments
Closed

Cannot rewrite responses to empty NOERROR #4133

ameshkov opened this issue Jan 14, 2022 · 0 comments
Assignees
@EugeneOne1
Labels
bug P4: Low
Milestone
v0.107.3

Comments

@ameshkov
Copy link
Member

Here's where we could need this:
#4021 (comment)

It's not a high priority issue, but should be trivial to fix.
@ameshkov ameshkov added this to the v0.107.3 milestone Jan 14, 2022
adguard pushed a commit to AdguardTeam/urlfilter that referenced this issue Jan 18, 2022
@EugeneOne1
Pull request: 4133 empty rewrite
6f750ac 
Merge in DNS/urlfilter from 4133-empty-rewrite to master

Updates AdguardTeam/AdGuardHome#4133

Squashed commit of the following:

commit 3372150
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Jan 18 21:17:19 2022 +0300

    rules: support some more empty rewrites

commit 94c02a4
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Jan 18 18:13:37 2022 +0300

    rules: add empty noerror rewrite

commit 9b3393b
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Jan 18 17:47:00 2022 +0300

    rules: imp rules parsing
adguard pushed a commit that referenced this issue Jan 21, 2022
@EugeneOne1 @ainar-g
cherry-pick: 4133 empty rewrite
de1a7ce 
Merge in DNS/adguard-home from 4133-empty-rewrite to master

Closes #4133.

Squashed commit of the following:

commit 4d2313c
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Jan 18 21:36:21 2022 +0300

    all: log changes

commit 5b8e392
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Jan 18 21:32:57 2022 +0300

    all: upd urlfilter
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 4133 empty rewrite
2290362 
Merge in DNS/adguard-home from 4133-empty-rewrite to master

Closes AdguardTeam#4133.

Squashed commit of the following:

commit 4d2313c
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Jan 18 21:36:21 2022 +0300

    all: log changes

commit 5b8e392
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Jan 18 21:32:57 2022 +0300

    all: upd urlfilter
@GTVolk GTVolk mentioned this issue Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
bug P4: Low
Projects
None yet
Milestone
v0.107.3
Development

No branches or pull requests
2 participants
@ameshkov @EugeneOne1