Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong AGHome service status #4273

Closed
Chinaski1 opened this issue Feb 10, 2022 · 5 comments
Closed

Wrong AGHome service status #4273

Chinaski1 opened this issue Feb 10, 2022 · 5 comments
Assignees
@EugeneOne1
Labels
bug external libs Issues that require changes in external libraries. P4: Low
Milestone
v0.107.7

Comments

@Chinaski1
Copy link
Member

  1. Open the console and stop the service;
  2. Check its status;
  3. Status shows not installed instead of stopped.

Screenshot with the issue
@Chinaski1 Chinaski1 added this to the v0.107.4 milestone Feb 10, 2022
@EugeneOne1
Copy link
Member

As for macOS, the package service has a related issue (kardianos/service#285) which currently isn't resolved. I suppose we should come up with some workaround, perhaps a fork.

@EugeneOne1 EugeneOne1 added the external libs Issues that require changes in external libraries. label Feb 14, 2022
@ainar-g ainar-g modified the milestones: v0.107.4, v0.107.5 Feb 18, 2022
@ainar-g
Copy link
Contributor

ainar-g commented Feb 18, 2022

@EugeneOne1, I do think that if we are able to make a version that solves the issue then we should make a fork, propose a merge, and use the fork until our fix is merged.

@EugeneOne1
Copy link
Member

It's also reproducable on Linux with systemd.

@ainar-g ainar-g modified the milestones: v0.107.6, v0.107.7 Apr 6, 2022
@EugeneOne1
Copy link
Member

It seems updating the github.com/kardianos/service to the v1.2.1 have fixed the status issue on both launchd (macOS) and systemd (Linux) systems.

@Chinaski1, could you please try to reproduce it in the latest edge/beta builds?

@Chinaski1
Copy link
Member Author

image

adguard pushed a commit that referenced this issue May 18, 2022
@EugeneOne1
Pull request: all: log changes
79d85a2 
Updates #4273.

Squashed commit of the following:

commit ebae1a4
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed May 18 14:48:16 2022 +0300

    all: log changes
adguard pushed a commit that referenced this issue Jun 2, 2022
@EugeneOne1 @ainar-g
cherry-pick: all: log changes
113f94f 
Updates #4273.

Squashed commit of the following:

commit ebae1a4
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed May 18 14:48:16 2022 +0300

    all: log changes
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: all: log changes
3ff7268 
Updates AdguardTeam#4273.

Squashed commit of the following:

commit ebae1a4
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed May 18 14:48:16 2022 +0300

    all: log changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
bug external libs Issues that require changes in external libraries. P4: Low
Projects
None yet
Milestone
v0.107.7
Development

No branches or pull requests
3 participants
@ainar-g @EugeneOne1 @Chinaski1