Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client ID does not work in DoT and DoQ #4782

Closed
3 tasks done
ZeroClover opened this issue Jul 26, 2022 · 3 comments
Closed
3 tasks done

Client ID does not work in DoT and DoQ #4782

ZeroClover opened this issue Jul 26, 2022 · 3 comments

Comments

@ZeroClover
Copy link

Prerequisites

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Issue Details

  • Version of AdGuard Home server:
    v0.108.0-b.10
  • How did you install AdGuard Home:
    GitHub Release
  • How did you setup DNS configuration:
    Dedicated server
  • If it's a router or IoT, please write device model:
    Dedicated server
  • CPU architecture:
    AMD64
  • Operating system and version:
    Debian 11

Expected Behavior

When requesting DNS via tls://<client-id>.domain.tld and quic://<client-id>.domain.tld, AdGuard Home should be able to correctly identify the Client ID and display it in the statistics.

Actual Behavior

The statistics do not show the Client ID, but only the IP address of the requesting party. Only DoH (https://domain.tld/dns-query/<client-id>) can be correctly counted as Client ID.

AdGuard Home has a wildcard certificate containing SAN *.domain.tld and has properly added wildcard DNS resolution.

The Server Name in the encryption settings has been left blank.

Tests performed using dnslookup as a client.

Screenshots

Screenshot:

01

02

03

04

@ainar-g
Copy link
Contributor

ainar-g commented Jul 26, 2022

Hello.

The Server Name in the encryption settings has been left blank.

This is the mistake. AdGuard Home uses the data from that field to separate the ClientIDs from the rest of the ClientHello TLS message.

We should probably mention that both in the UI as well as in the Wiki.

@ainar-g ainar-g self-assigned this Jul 26, 2022
@ainar-g ainar-g added this to the v0.107.9 milestone Jul 26, 2022
@ZeroClover
Copy link
Author

ZeroClover commented Jul 26, 2022

Sorry, it's my bad. I misunderstood the meaning of the prompt.

The Server Name field prompts that leaving it blank will accept incoming TLS connections for any domains, which I thought I needed to leave blank in order for the wildcard domain to work properly.

Should I keep this issue open?

@ainar-g
Copy link
Contributor

ainar-g commented Jul 26, 2022

Yes, we'll close it once the UI and the docs are updated.

adguard pushed a commit that referenced this issue Jul 26, 2022
Updates #4782.

Squashed commit of the following:

commit d350b38
Author: Natalia Sokolova <n.sokolova@adguard.com>
Date:   Tue Jul 26 18:39:38 2022 +0300

    client: imp wording

commit d078531
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Jul 26 17:16:41 2022 +0300

    client: imp tls server name label
@ainar-g ainar-g closed this as completed Jul 26, 2022
adguard pushed a commit that referenced this issue Aug 3, 2022
Updates #4782.

Squashed commit of the following:

commit d350b38
Author: Natalia Sokolova <n.sokolova@adguard.com>
Date:   Tue Jul 26 18:39:38 2022 +0300

    client: imp wording

commit d078531
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Jul 26 17:16:41 2022 +0300

    client: imp tls server name label
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Updates AdguardTeam#4782.

Squashed commit of the following:

commit d350b38
Author: Natalia Sokolova <n.sokolova@adguard.com>
Date:   Tue Jul 26 18:39:38 2022 +0300

    client: imp wording

commit d078531
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Jul 26 17:16:41 2022 +0300

    client: imp tls server name label
ehsan11100 pushed a commit to ehsan11100/AdGuard that referenced this issue Mar 26, 2024
Updates AdguardTeam/AdGuardHome#4782.

Squashed commit of the following:

commit 338b1df52b85054c71180b230c7b3f7bc7dfc992
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Jul 26 19:01:48 2022 +0300

    Configuration: imp server_name docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants