Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple servers per line for upstream file. #4977

Closed
3 tasks done
fernvenue opened this issue Sep 30, 2022 · 3 comments
Closed
3 tasks done

Multiple servers per line for upstream file. #4977

fernvenue opened this issue Sep 30, 2022 · 3 comments

Comments

@fernvenue
Copy link
Contributor

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to request a feature or enhancement and not ask a question

Description

What problem are you trying to solve?

Hi, I'm using upstream_dns_file to setting specific upstream for a large list, but I can only set one single upstream for these domains, I think we do need fallback server(s) for them.

Proposed solution

Support multiple servers per line for the rules like [/com/]1.1.1.1,1.0.0.1 or something like that will be so great :)

@rrfeng
Copy link

rrfeng commented Apr 14, 2023

I have a better idea. Since now we supports a default upstream group with a # following the domain line:

1.1.1.1
2.2.2.2
[/xxx.example.com/]#

why not a upstream group name:

1.1.1.1#cf
8.8.8.8#google
8.8.4.4#google
[/example.com/]#google

@13810169
Copy link

我有一个更好的主意。从现在开始,我们支持默认的上游组,在域行后面有一个 #:

1.1.1.1
2.2.2.2
[/xxx.example.com/]#

为什么不是上游组名:

1.1.1.1#cf
8.8.8.8#google
8.8.4.4#google
[/example.com/]#google

This will be more convenient for Chinese users。Hope that developers can be online as soon as possible this function

@ainar-g ainar-g assigned schzhn and unassigned ameshkov Oct 9, 2023
adguard pushed a commit that referenced this issue Oct 27, 2023
Updates #4977.

Squashed commit of the following:

commit da28c1b
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Fri Oct 27 17:24:38 2023 +0300

    all: fix typo

commit d6bca6b
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Fri Oct 27 14:44:20 2023 +0300

    all: add todo

commit 3087551
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Wed Oct 25 20:00:17 2023 +0300

    all: imp docs

commit 04003c3
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Wed Oct 25 16:59:14 2023 +0300

    all: multiple domain specific upstreams
@schzhn
Copy link
Member

schzhn commented Nov 10, 2023

The upcoming v0.107.41 release will contain support for multiple domain specific upstreams per line.
[/domain1/domain2/../domainN/]upstream1 upstream2 .. upstreamN

@ainar-g ainar-g closed this as completed Nov 13, 2023
annguyen0 pushed a commit to annguyen0/AdGuardHome that referenced this issue Nov 27, 2023
Updates AdguardTeam#4977.

Squashed commit of the following:

commit da28c1b
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Fri Oct 27 17:24:38 2023 +0300

    all: fix typo

commit d6bca6b
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Fri Oct 27 14:44:20 2023 +0300

    all: add todo

commit 3087551
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Wed Oct 25 20:00:17 2023 +0300

    all: imp docs

commit 04003c3
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Wed Oct 25 16:59:14 2023 +0300

    all: multiple domain specific upstreams
@ainar-g ainar-g modified the milestones: v0.108.0, v0.107.41 Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants