Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to fully disable logging/error #7079

Closed
3 tasks done
zbugrkx opened this issue Jun 14, 2024 · 3 comments
Closed
3 tasks done

Add option to fully disable logging/error #7079

zbugrkx opened this issue Jun 14, 2024 · 3 comments
Assignees
@schzhn
Labels
feature request P4: Low
Milestone
v0.107.52

Comments

@zbugrkx
Copy link

zbugrkx commented Jun 14, 2024

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to request a feature or enhancement and not ask a question

The problem

Following discussion in #7053 this is to implement an option, in the YAML or other, to fully disable writing to logs for errors/infos (.out / . err). This is in addition to the future enhancement to add logging to journald

Proposed solution

Implement option to disable all logging in yaml or config

Alternatives considered and additional information

No response
@ainar-g ainar-g added this to the v0.107.52 milestone Jun 17, 2024
adguard pushed a commit that referenced this issue Jun 20, 2024
@schzhn
Pull request 2242: 7079-log-enabled
65b7d23 
Updates #7079.

Squashed commit of the following:

commit 477c5ed
Merge: d3c64e0 6472140
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Thu Jun 20 19:31:54 2024 +0300

    Merge branch 'master' into 7079-log-enabled

commit d3c64e0
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Thu Jun 20 16:02:42 2024 +0300

    home: imp docs

commit 7658c9b
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Thu Jun 20 14:17:08 2024 +0300

    all: log enabled
@schzhn
Copy link
Member

schzhn commented Jun 21, 2024

Support for the configuration property log.enabled has been added in the edge release.

hoang-rio added a commit to abpvn/AdGuardHome that referenced this issue Jun 24, 2024
@hoang-rio @EugeneOne1 @schzhn
Feature/filters list per client (#7)
0d0f593 
* Pull request 2241: 7075 Doc load-balancing

Updates AdguardTeam#7075.

Squashed commit of the following:

commit cd889bd
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Thu Jun 20 17:20:13 2024 +0300

    client: imp text

commit 3d51d48
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed Jun 19 13:47:48 2024 +0300

    client: imp ui text

* Pull request 2242: 7079-log-enabled

Updates AdguardTeam#7079.

Squashed commit of the following:

commit 477c5ed
Merge: d3c64e0 6472140
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Thu Jun 20 19:31:54 2024 +0300

    Merge branch 'master' into 7079-log-enabled

commit d3c64e0
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Thu Jun 20 16:02:42 2024 +0300

    home: imp docs

commit 7658c9b
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Thu Jun 20 14:17:08 2024 +0300

    all: log enabled

---------

Co-authored-by: Eugene Burkov <e.burkov@adguard.com>
Co-authored-by: Stanislav Chzhen <s.chzhen@adguard.com>
@gkajaia1979
Copy link

Better to implement to disable separate types of logs. for example adguard home error logs only that file AdGuardHome.err is growing fast in my case.

@ainar-g ainar-g closed this as completed Jul 3, 2024
@ainar-g ainar-g modified the milestones: v0.107.53, v0.107.52 Jul 3, 2024
@gkajaia1979
Copy link

How do I implement log.enabled in yaml?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schzhn schzhn

Labels
feature request P4: Low
Projects
None yet
Milestone
v0.107.52
Development

No branches or pull requests
4 participants
@zbugrkx @ainar-g @schzhn @gkajaia1979