Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add possibility to setup schedule for blocked services on per-client basis #951

Closed
maximtop opened this issue Aug 22, 2019 · 30 comments
Closed

Add possibility to setup schedule for blocked services on per-client basis #951

maximtop opened this issue Aug 22, 2019 · 30 comments
Assignees
@ainar-g
Labels
feature request P3: Medium
Milestone
v0.107.37

Comments

@maximtop
Copy link
Contributor

It would be cool to add a schedule for blocked services/sites in order to turn on/off automatically.
@ghost
Copy link

ghost commented Aug 22, 2019 •
edited by ghost

Edited @ApeviaX

Settings button

Screenshot_87

65788378-2211c280-e185-11e9-97f9-fae7d826e1e2

(Block VPN - most home users never willing to own or use dedicated firewalls and AGH able to run on low end devices then that will be helpful)

Service availability page - might be perfect for kids and teenagers without mention adguard may decrease priority to find alternative access methods.

  • Youtube will be available at 8pm
  • Steam access available from 2:00pm to 11:59pm

Some prepaid internet package offer ISPs has such notification page when exceed quota or visit to certain subscribed services.

This was referenced Aug 25, 2019
Open
Closed
@ghost ghost mentioned this issue Nov 3, 2019
Open
@ghost ghost mentioned this issue Nov 24, 2019
Open
@ghost ghost mentioned this issue Dec 7, 2019
Open
@ghost ghost mentioned this issue Apr 9, 2020
Closed
@ghost ghost mentioned this issue Apr 17, 2020
Closed
3 tasks
@ameshkov ameshkov mentioned this issue May 11, 2020
Closed
3 tasks
@Aikatsui Aikatsui mentioned this issue May 18, 2020
Open
@ameshkov ameshkov mentioned this issue Jun 29, 2020
Closed
@ameshkov
Copy link
Member

One more relevant feature request:
#1838

@ameshkov ameshkov changed the title [Feature request] Add possibility to setup schedule for blocked services [Feature request] Add possibility to setup schedule for blocked services (and more) on per-client basis Jun 29, 2020
@ameshkov
Copy link
Member

And one more:
#1594

This was referenced Jul 13, 2020
Closed
Open
@temporallyaccount
Copy link

More blocked services feature > #1692

@Aikatsui Aikatsui mentioned this issue Jul 16, 2020
Closed
3 tasks
@Aikatsui Aikatsui mentioned this issue Aug 1, 2020
Closed
@ay89607
Copy link

ay89607 commented Sep 1, 2020

Hi! I'd like to contribute to development of this feature. Is there design approach/hint which configuration files/format/etc is preferable? I.e. how should I take it form here?

@ameshkov
Copy link
Member

ameshkov commented Sep 1, 2020

@ay89607 thank you! Let's get back to it in approximately 2 months, we're planning to conduct a massive refactoring, implementing this feature right now may be problematic.

@Aikatsui Aikatsui mentioned this issue Oct 29, 2020
Open
@Aikatsui Aikatsui mentioned this issue Nov 17, 2020
Closed
@ameshkov ameshkov added this to the v0.109 milestone Nov 18, 2020
@Aikatsui Aikatsui mentioned this issue Dec 14, 2020
Closed
@ameshkov ameshkov mentioned this issue Jan 18, 2021
Closed
@Mosney
Copy link

Mosney commented Apr 14, 2021

Schedule blocked have any progress until now?

@ameshkov
Copy link
Member

Not yet

@allhailCdosdude

This comment was marked as off-topic.

Sign in to view
@ainar-g
Copy link
Contributor

ainar-g commented Mar 25, 2022 •
edited

@danmed, @allhailCdosdude, please do not add “+1” type messages, as reacting to the original message with a “:+1:” is enough. The feature is already scheduled for the next major release, but precise timing is still unclear.

@ainar-g ainar-g changed the title [Feature request] Add possibility to setup schedule for blocked services (and more) on per-client basis Add possibility to setup schedule for blocked services on per-client basis May 20, 2022
@BrianGilbert BrianGilbert mentioned this issue Jun 15, 2022
Closed
@BobWs
Copy link

BobWs commented Jun 15, 2022

So as understand this feature is planned for version 1.0.8? 2023?

@BrianGilbert
Copy link

So as understand this feature is planned for version 1.0.8? 2023?

no due date https://github.com/AdguardTeam/AdGuardHome/milestone/24

@ainar-g ainar-g mentioned this issue Mar 6, 2023
Closed
3 tasks
@ainar-g ainar-g mentioned this issue Apr 19, 2023
Closed
3 tasks
@moshecom
Copy link

moshecom commented Jun 5, 2023

@ainar-g I'd like to contribute and help write this functionality.
Let me know what's the best way to help.

Thanks,
Moshe

@ainar-g
Copy link
Contributor

ainar-g commented Jun 5, 2023

@moshecom, hello and thank you for the suggestion, but we're already in the process of implementing it. No exact timeframes, but we hope to ship it with the next release.

adguard pushed a commit that referenced this issue Jun 22, 2023
@schzhn
Pull request 1886: fix-blocked-services-client-schedule
37e046a 
Merge in DNS/adguard-home from fix-blocked-services-client-schedule to master

Updates #951.

Squashed commit of the following:

commit 1c89095
Merge: ac0b722 f40ef76
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Thu Jun 22 15:54:03 2023 +0300

    Merge branch 'master' into fix-blocked-services-client-schedule

commit ac0b722
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Thu Jun 22 14:32:03 2023 +0300

    home: fix typo

commit 64eb519
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Thu Jun 22 14:23:07 2023 +0300

    home: add test case

commit c7b60f3
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Thu Jun 22 12:00:24 2023 +0300

    home: imp code

commit 7806c92
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Wed Jun 21 20:49:47 2023 +0300

    home: add tests

commit d37c9fd
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Wed Jun 21 18:49:43 2023 +0300

    home: fix client blocked services
adguard pushed a commit that referenced this issue Jun 27, 2023
@schzhn
Pull request 1883: 951-blocked-services-client-schedule
d881813 
Updates #951.

Squashed commit of the following:

commit 94e4766
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Tue Jun 27 17:21:41 2023 +0300

    chlog: upd docs

commit b4022c3
Merge: cfa24ff e7e6384
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Tue Jun 27 16:33:20 2023 +0300

    Merge branch 'master' into 951-blocked-services-client-schedule

commit cfa24ff
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Tue Jun 27 15:04:10 2023 +0300

    chlog: imp docs

commit dad2759
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Mon Jun 26 17:38:08 2023 +0300

    home: imp err msg

commit 7d9ba98
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Mon Jun 26 16:58:00 2023 +0300

    all: add tests

commit 8e952fc
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Fri Jun 23 16:36:10 2023 +0300

    schedule: add todo

commit 723573a
Merge: 2151ab2 e54fc9b
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Fri Jun 23 11:40:03 2023 +0300

    Merge branch 'master' into 951-blocked-services-client-schedule

commit 2151ab2
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Fri Jun 23 11:37:49 2023 +0300

    all: add tests

commit 81ab341
Merge: aa7ae41 66345e8
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Thu Jun 22 17:59:01 2023 +0300

    Merge branch 'master' into 951-blocked-services-client-schedule

commit aa7ae41
Merge: 304389a 06d465b
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Wed Jun 21 17:10:11 2023 +0300

    Merge branch 'master' into 951-blocked-services-client-schedule

commit 304389a
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Wed Jun 21 17:05:31 2023 +0300

    home: imp err msg

commit 29cfc7a
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Tue Jun 20 20:42:59 2023 +0300

    all: imp err handling

commit 8543868
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Tue Jun 20 18:21:50 2023 +0300

    all: upd chlog

commit c5b614d
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Tue Jun 20 14:37:47 2023 +0300

    all: add blocked services schedule
@sikosis
Copy link

sikosis commented Aug 8, 2023

Very much looking forward to this ... even just a way to do the service blocking via command line would be good, then I can just use a cron job. Been searching and can't find any info about doing this. I use to be able to do this with Pi-hole.

@dongu54321
Copy link

I think we can use the API and cronjob to achieve that.
We have /parental/enable and /parental/disenable. Also
/filtering/add_url and /filtering/remove_url.
i'm trying this now!
more about the api

adguard pushed a commit that referenced this issue Aug 29, 2023
@schzhn
Pull request 1907: 951-blocked-services-schedule-api
aac36a2 
Updates #951.

Squashed commit of the following:

commit 6b840fd
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Tue Aug 29 19:53:03 2023 +0300

    client: imp docs more

commit 7fc8f03
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Tue Aug 29 19:40:00 2023 +0300

    client: imp docs

commit 00bc14d
Author: Ildar Kamalov <ik@adguard.com>
Date:   Mon Aug 28 18:43:49 2023 +0300

    try to fix lock file

commit d749df7
Merge: c69f923 e1f6229
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Mon Aug 28 18:14:02 2023 +0300

    Merge branch 'master' into 951-blocked-services-schedule-api

commit c69f923
Author: Ildar Kamalov <ik@adguard.com>
Date:   Mon Aug 28 17:16:20 2023 +0300

    revert eslintrc

commit b37916c
Author: Ildar Kamalov <ik@adguard.com>
Date:   Mon Aug 28 12:02:39 2023 +0300

    fix translations

commit f5bb67d
Author: Ildar Kamalov <ik@adguard.com>
Date:   Mon Aug 28 11:43:57 2023 +0300

    fix helpers

commit 13ec6a8
Author: Ildar Kamalov <ik@adguard.com>
Date:   Mon Aug 28 11:24:57 2023 +0300

    remove todo

commit 23724ec
Author: Ildar Kamalov <ik@adguard.com>
Date:   Mon Aug 28 09:56:56 2023 +0300

    add clients schedule form

commit 84d29e5
Author: Ildar Kamalov <ik@adguard.com>
Date:   Fri Aug 25 17:44:40 2023 +0300

    fix schedule form

commit 83e4017
Author: Ildar Kamalov <ik@adguard.com>
Date:   Fri Aug 18 12:58:16 2023 +0300

    remove unused

commit ef2b68e
Author: Ildar Kamalov <ik@adguard.com>
Date:   Fri Aug 18 12:57:37 2023 +0300

    client: fix translation string

commit 32ea80c
Author: Ildar Kamalov <ik@adguard.com>
Date:   Fri Aug 18 12:26:26 2023 +0300

    wip schedule

commit 9b77087
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Fri Jul 21 14:29:50 2023 +0300

    all: imp naming

commit ea4e951
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Wed Jul 19 18:09:27 2023 +0300

    all: imp code

commit 98a705b
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Tue Jul 18 18:23:26 2023 +0300

    all: imp naming

commit 4f84b55
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Fri Jul 14 15:01:17 2023 +0300

    all: add global schedule api

commit 87cf164
Merge: cabb80a 2adc862
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Fri Jul 14 12:09:29 2023 +0300

    Merge branch 'master' into 951-blocked-services-schedule-api

commit cabb80a
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Thu Jul 13 13:37:23 2023 +0300

    openapi: fix typo

commit 2279b03
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Thu Jul 13 12:26:19 2023 +0300

    all: imp docs

... and 3 more commits
@ainar-g ainar-g modified the milestones: v0.108.0, v0.107.37 Sep 6, 2023
@ainar-g
Copy link
Contributor

ainar-g commented Sep 6, 2023

This will be released in the upcoming v0.107.37.

@ainar-g ainar-g closed this as completed Sep 6, 2023
@ainar-g ainar-g modified the milestones: v0.107.38, v0.107.37 Sep 7, 2023
@grf692
Copy link

grf692 commented Sep 8, 2023

Hi, I apologize if I did not get it, but the title says "on per-client basis" - which is the feature I was looking for - and I don't think it is what is provided in 0.107.37. This release "only" enables to schedule the on/off the service-blocking filter globally. Am I wrong ?

@ainar-g
Copy link
Contributor

ainar-g commented Sep 8, 2023

@grf692, I'm afraid that you are, heh. The schedule for a client is the next tab after blocked services, and it's called Pause service blocking. The UI needs improvement, but that will probably come in v0.108 cycle.

@grf692
Copy link

grf692 commented Sep 8, 2023

Sorry for being stupid, I did see the "Pause service blocking" but I can't find where I select the individual client/device. All I see is that I can add a schedule per week day to pause the service blocking filter globally (= for all clients).
Can you share a screenshot where I can select the individual client/device please ?

@ainar-g
Copy link
Contributor

ainar-g commented Sep 8, 2023

@grf692, Settings → Client settings → New client/Edit. Pause service blocking tab is to the right of the Block specific services tab.

Screen Shot 2023-09-08 at 11 41 26

@BrianGilbert
Copy link

Thanks for adding this feature.

A not that it appears you can only add the same schedule for every day of the week.

When I created a schedule for the weekend, it is replaced altogether in the UI when I subsequently add a different schedule for weekdays.

@ainar-g
Copy link
Contributor

ainar-g commented Sep 11, 2023

@BrianGilbert, that's #6177.

@venethia
Copy link

Thanks for adding this feature.

If I want to suspend a service two times the same day from 8:00 to 14:00 and from 20:00 to 23:59 how can I do?

@ainar-g
Copy link
Contributor

ainar-g commented Oct 18, 2023

@venethia, there is only one interval currently. You can create a feature request for multiple intervals within the same weekday.

@venethia
Copy link

venethia commented Oct 18, 2023 •
edited

Done: #6326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ainar-g ainar-g

Labels
feature request P3: Medium
Projects
None yet
Milestone
v0.107.37
Development

No branches or pull requests