https://github.com/AdguardTeam/AdguardBrowserExtension/issues/374

Tabs API
AdguardTeam · Sep 26, 2016 · b45633a · b45633a
1 parent 8f18a7e
commit b45633a
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/Extension/browser/chrome/lib/background-page.js b/Extension/browser/chrome/lib/background-page.js
@@ -28,12 +28,14 @@ var browser = browser || chrome;
 
 		var onMessage = {
 			addListener: function (callback) {
+				// https://developer.chrome.com/extensions/runtime#event-onMessage
 				adguard.runtimeImpl.onMessage.addListener(function (message, sender, sendResponse) {
 					var senderOverride = Object.create(null);
 					if (sender.tab) {
 						senderOverride.tab = adguard.tabsImpl.fromChromeTab(sender.tab);
 					}
-					callback(message, senderOverride, sendResponse);
+					// Don't forget return callback result for asynchronous message passing
+					return callback(message, senderOverride, sendResponse);
 				});
 			}
 		};