Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome Extension - ext-CSS not always applied #1009

Closed
BlazDT opened this issue Apr 25, 2018 · 5 comments
Closed

Chrome Extension - ext-CSS not always applied #1009

BlazDT opened this issue Apr 25, 2018 · 5 comments
Assignees
Milestone

Comments

@BlazDT
Copy link

BlazDT commented Apr 25, 2018

When opening this amazon page, ext-CSS is applied as it should:

https://adguardteam.github.io/AnonymousRedirect/redirect.html?url=https%3A%2F%2Fwww.amazon.de%2Fs%2Fref%3Dsr_pg_2%3Frh%3Dn%253A12950651%252Cn%253A359480031%252Ck%253Agummiball%26page%3D2%26keywords%3Dgummiball%26ie%3DUTF8%26qid%3D1524679180

When changing to the next page of results, it is not applied anymore:

amazon.de,amazon.com,amazon.co.uk,amazon.fr,amazon.it,amazon.es##.s-result-list > .s-result-item[-ext-has='span[data-a-popover*="sponsored-header"]']

The same rule works fine in AdGuard for Windows which both are using ext-CSS 1.10.

AdguardTeam/AdguardFilters#15294

@BlazDT
Copy link
Author

BlazDT commented Jun 17, 2018

@vozersky and @maximtop
Could you please check if the new Extension is applying the ext-CSS rule (without redefining inisStick on that site):

AdguardTeam/AdguardFilters#17436 (comment)

@ameshkov
Copy link
Member

@BlazDT talking about this rule?
3movs.com###side_col_video_view > div.section:has(> div.block_header_side > h4:contains(Advertisement))

@BlazDT
Copy link
Author

BlazDT commented Jun 18, 2018

Yes, any ext-css rule which targets that div.section.

@maximtop
Copy link
Contributor

@BlazDT
3movs.com###side_col_video_view > div.section:has(> div.block_header_side > h4:contains(Advertisement))
this rule is applying correctly in the new version of extension

@BlazDT
Copy link
Author

BlazDT commented Jun 29, 2018

Good :)
Please close the issue when new version is public beta.

@zebrum zebrum closed this as completed Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants