Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assistant iframe styles are affected by cosmetic rules specific for websites #1848

Closed
Alex-302 opened this issue Aug 30, 2021 · 1 comment
Closed

Assistant iframe styles are affected by cosmetic rules specific for websites #1848

Alex-302 opened this issue Aug 30, 2021 · 1 comment
Assignees
@slavaleleka
Labels
Bug Priority: P4 Resolution: Fixed Status: Closed Version: AdGuard v4.3.x patch 3

Comments

@Alex-302
Copy link
Member

@adguard-bot commented on Mon Aug 30 2021

Issue URL (Incorrect Blocking)

https://www.tv2.no/a/6805835/

Comment

When trying to block an element with Nordic Filters turned on, the buttons at the bottom of the AdGuard popup are missing ("Select a different element", "Preview", "Block"). When Nordic Filters (under "Language-specific") are turned off, the buttons appear. Possible conflict between Nordic Filters and element blocking?

Screenshots

Screenshot 1

Screenshot 1

Screenshot 2

Screenshot 2

System configuration

Information value
AdGuard product: AdGuard Browser extension v3.6.6
Browser: Chrome
Stealth mode: disabled
Filters: Ad Blocking:
AdGuard Base

Language-specific:
Dandelion Sprout's Nordic Filters
Other extensions used: nothing relevant

@DandelionSprout commented on Mon Aug 30 2021

I seem to have found the problem: AdGuard's element picker is using html and body elements for seemingly no valid reason, which causes www.tv2.no#$#body:not(.broom, .lab) { padding-top: 70px !important } to take effect for it.

This seems like a pretty severe bug in AdGuard Browser Extension, and it's a 50:50 chance if I can even make a good temporary fix for it.

@DandelionSprout commented on Mon Aug 30 2021

I've now added a tempfix for this in DandelionSprout/adfilt@996d2e3, but it is by no means a good idea in the long run.
@Alex-302 Alex-302 mentioned this issue Aug 30, 2021
Closed
@matso167
Copy link

I don't have Nordic Filters enabled, but the element picker popup doesn't show at all on website https://ylilauta.org/

@adguard-bot adguard-bot changed the title Element picker popup may be broken by filtering rules Assistant iframe styles are affected by cosmetic rules specific for websites Nov 28, 2023
adguard pushed a commit to AdguardTeam/tsurlfilter that referenced this issue Mar 25, 2024
@slavaleleka
do not inject cosmetic rules into an assistant frame. AG-9829
b43c3ea 
AdguardTeam/AdguardBrowserExtension#1848

Squashed commit of the following:

commit 7dd337d
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Mar 25 15:50:34 2024 +0300

    packages/tswebextension/CHANGELOG.md edited online with Bitbucket

commit d572159
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri Mar 22 19:19:23 2024 +0200

    decrease Assistant.FRAME_CREATION_LIMIT_MS to 100

commit 60ef472
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri Mar 22 19:13:18 2024 +0200

    add url checking

commit 0f3c5c1
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri Mar 22 17:50:33 2024 +0200

    make isAssistantFrame() a static method of Assistant

commit c1b3ebf
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri Mar 22 16:31:08 2024 +0200

    fix setAssistantInitTimestamp()

commit bfed0f7
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Thu Mar 21 21:25:18 2024 +0200

    do not inject cosmetic rules into an assistant frame
adguard pushed a commit to AdguardTeam/tsurlfilter that referenced this issue Mar 25, 2024
@slavaleleka
improve assistant iframe checking for cosmetic rules injection. AG-9829
72f4dae 
AdguardTeam/AdguardBrowserExtension#1848

Squashed commit of the following:

commit b99cb97
Merge: 76e71d2 15fa192
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Mar 25 19:24:35 2024 +0200

    Merge branch 'master' into fix/AG-9829-02

commit 76e71d2
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Mar 25 18:10:44 2024 +0200

    improve assistant iframe checking for cosmetic rules injection - increase FRAME_CREATION_LIMIT_MS to 200
adguard pushed a commit that referenced this issue Mar 27, 2024
@slavaleleka
do not inject cosmetic rules into an assistant frame. #1848 AG-9829
fb0a3da 
Squashed commit of the following:

commit aabfaa3
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed Mar 27 15:12:50 2024 +0200

    fix changelog

commit f93e492
Merge: 50909e7 ceccb2f
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed Mar 27 15:10:56 2024 +0200

    Merge branch 'master' into fix/AG-9829-01

commit 50909e7
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue Mar 26 16:22:53 2024 +0200

    update tswebextension to v1.0.18

commit dae81de
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Mar 25 17:24:15 2024 +0200

    update changelog

commit 59685aa
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Mar 25 17:08:20 2024 +0200

    update tswebextension to v1.0.17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavaleleka slavaleleka

Labels
Bug Priority: P4 Resolution: Fixed Status: Closed Version: AdGuard v4.3.x patch 3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Alex-302 @adguard-bot @matso167 @slavaleleka @stanislav-atr