Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong rules are constructed for website with non-standard port #236

Closed
ameshkov opened this issue Apr 22, 2016 · 0 comments
Closed

Wrong rules are constructed for website with non-standard port #236

ameshkov opened this issue Apr 22, 2016 · 0 comments
Assignees
@Mizzick
Labels
Bug Safari
Milestone
2.3

Comments

@ameshkov
Copy link
Member

Test website: portquiz.net:8080

Problem
Element blocking tool creates invalid rules for such websites.
The rule will be like that portquiz.net:8080##H1:first-child

While it should be portquiz.net##H1
@ameshkov ameshkov added this to the 2.3 milestone Apr 22, 2016
Mizzick added a commit that referenced this issue Apr 23, 2016
@Mizzick
#236 fix
a083279
@Mizzick Mizzick closed this as completed Apr 23, 2016
ameshkov added a commit that referenced this issue Apr 24, 2016
@ameshkov
Merge pull request #237 from AdguardTeam/feature/issues/236
6726552 
#236 fix
ameshkov pushed a commit that referenced this issue Dec 28, 2018
@maximtop
Merge pull request #236 in EXTENSIONS/browser-extension from fix/1122…
7e3e528 
… to feature/redesign

* commit '96e75a14aac0163352765a6fa0328b3762bcf717':
  add tests, and move rule.isIgnored check in RequestFilter addRule method
  fixes
  do not ignore rules with extension modifier, but don't add them in the request filter
  fix/1122 make extension rule unknown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mizzick Mizzick

Labels
Bug Safari
Projects
None yet
Milestone
2.3
Development

No branches or pull requests
2 participants
@ameshkov @Mizzick