Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Russian translation detected in Edge when installing extension from MS add-ons #2430

Closed
AleksandrKalininAdGuard opened this issue Aug 14, 2023 · 2 comments
Closed

Russian translation detected in Edge when installing extension from MS add-ons #2430

AleksandrKalininAdGuard opened this issue Aug 14, 2023 · 2 comments
Assignees
@slavaleleka
Labels
Bug Priority: P4 Resolution: Fixed Status: Closed Version: AdGuard v4.2 patch 1

Comments

@AleksandrKalininAdGuard
Copy link

AleksandrKalininAdGuard commented Aug 14, 2023 •
edited

AdGuard Extension version

4.1.57

Browser version

MS Edge, Version 115.0.1901.203 (Official build) (64-bit)

OS version

Win 11

What filters do you have enabled?

No response

What Stealth Mode options do you have enabled?

No response

Issue Details

When installing the AdGuard browser extension from MS add-ons, MS Edge detects Russian language and offers translation even if the page doesn't contain Russian language.

Expected Behavior

The translation option from Russian to English shouldn't appear.

Screenshots

Screenshot 1:

Additional Information

No response
@AleksandrKalininAdGuard
Copy link
Author

  • CRM 791437

@adguard-bot adguard-bot assigned maximtop and unassigned Birbber Aug 14, 2023
@adguard-bot adguard-bot assigned zhelvis and unassigned maximtop Aug 15, 2023
@ameshkov
Copy link
Member

We can also use this:
https://www.w3.org/International/questions/qa-translate-flag

@adguard-bot adguard-bot assigned stanislav-atr and unassigned zhelvis Aug 29, 2023
adguard pushed a commit that referenced this issue Sep 12, 2023
@slavaleleka
fix filter download page lang. #2430 AG-24846
40c5003 
Squashed commit of the following:

commit 86dfba8
Merge: 2986821 dd5cf75
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue Sep 12 17:23:22 2023 +0300

    Merge branch 'master' into fix/AG-24846

commit 2986821
Merge: 045dafa f07c2f7
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Sep 11 18:58:02 2023 +0300

    Merge branch 'master' into fix/AG-24846

commit 045dafa
Merge: fe02d56 e1111ec
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Sep 11 18:19:27 2023 +0300

    Merge branch 'master' into fix/AG-24846

commit fe02d56
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Sep 11 18:19:25 2023 +0300

    update changelog

commit 70ca6bc
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Sep 11 18:03:18 2023 +0300

    fix filter download page lang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavaleleka slavaleleka

Labels
Bug Priority: P4 Resolution: Fixed Status: Closed Version: AdGuard v4.2 patch 1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@ameshkov @maximtop @zhelvis @adguard-bot @slavaleleka @stanislav-atr @Birbber @AleksandrKalininAdGuard