Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Adguard filters from file system to storage #253

Closed
ameshkov opened this issue May 24, 2016 · 4 comments
Closed

Move Adguard filters from file system to storage #253

ameshkov opened this issue May 24, 2016 · 4 comments
Assignees
@Mizzick
Labels
Chromium
Milestone
2.3

Comments

@ameshkov
Copy link
Member

ameshkov commented May 24, 2016 •
edited

  1. We currently use a "FilterStorage" class to manage filters storage.

2) Don't forget about handling it on extension update.
@ameshkov ameshkov added this to the 2.3 milestone May 24, 2016
Mizzick added a commit that referenced this issue May 24, 2016
@Mizzick
#253 file storage
e310ab3
Mizzick added a commit that referenced this issue May 24, 2016
@Mizzick
#253 file storage
497d8b1
@Mizzick
Copy link
Contributor

Mizzick commented May 24, 2016

Fixed

@Mizzick Mizzick closed this as completed May 24, 2016
Mizzick added a commit that referenced this issue May 24, 2016
@Mizzick
#253 file storage refactoring
6db2c08
Mizzick added a commit that referenced this issue May 24, 2016
@Mizzick
#253 file storage refactoring
d35974d
Mizzick added a commit that referenced this issue May 24, 2016
@Mizzick
#253 file storage refactoring
580e5a5
@ameshkov
Copy link
Member Author

@Mizzick don't forget to add unlimited storage permission!

@ameshkov ameshkov reopened this May 24, 2016
@Mizzick Mizzick closed this as completed May 25, 2016
Mizzick added a commit that referenced this issue May 25, 2016
@Mizzick
#253 file storage
da52078
@ameshkov
Copy link
Member Author

Actually we made it wrong now.

You are currently using localStorage which has size restriction (5MB).
Instead we should use "browser.storage":
https://developer.chrome.com/extensions/storage
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/storage

@ameshkov ameshkov reopened this May 30, 2016
ameshkov added a commit that referenced this issue May 30, 2016
@ameshkov
https://github.com/AdguardTeam/AdguardBrowserExtension/issues/253
d0871ea
@ameshkov
Copy link
Member Author

Done

ameshkov pushed a commit that referenced this issue Dec 28, 2018
@maximtop
Merge pull request #253 in EXTENSIONS/browser-extension from fix/1129…
da975a3 
… to feature/redesign

* commit '0b4df194cd09eabd826efdf8d2337345b7ada531':
  fix/1129 replace and update minified moment.js
  fix/1129 replace and update minified Dropbox-sdk
  fix/1129 replace minified deferrer.js
  fix/1129 replace minified version of library with not minified
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mizzick Mizzick

Labels
Chromium
Projects
None yet
Milestone
2.3
Development

No branches or pull requests
2 participants
@ameshkov @Mizzick