Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send OS name and version as system_version to ReportsWebApp #2535

Closed
Alex-302 opened this issue Oct 12, 2023 · 0 comments
Closed

Send OS name and version as system_version to ReportsWebApp #2535

Alex-302 opened this issue Oct 12, 2023 · 0 comments
Assignees
@slavaleleka
Labels
Feature Request Priority: P4 Resolution: Fixed Status: Closed Version: AdGuard v4.2.x (patch 2)

Comments

@Alex-302
Copy link
Member

Alex-302 commented Oct 12, 2023 •
edited

Issue Details

AdguardTeam/AdguardForAndroid#5025

Proposed solution

Send Operating System name + version to ReportsWebApp
https://github.com/AdguardTeam/ReportsWebApp

Maybe navigator.appVersion output can be used.

'5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/117.0.0.0 Safari/537.36'
to
Windows 10 x64

But in Windows 11 it also returns Windows NT 10.0. Can be detected like described here.

Alternative solution

No response
@slavaleleka slavaleleka changed the title Send Operating System name + version to ReportsWebApp Send OS name and version as system_version to ReportsWebApp Oct 12, 2023
adguard pushed a commit that referenced this issue Oct 16, 2023
@slavaleleka
sent system_version during issues reporting. #2535 AG-26665
95edb9d 
Squashed commit of the following:

commit af98f77
Merge: c594844 938b6a0
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri Oct 13 18:02:27 2023 +0300

    Merge branch 'master' into feature/AG-26665

commit c594844
Merge: 06904d6 08666bb
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri Oct 13 17:46:28 2023 +0300

    Merge branch 'master' into feature/AG-26665

commit 06904d6
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri Oct 13 17:42:24 2023 +0300

    get actual macos version if possible to be more specific

commit d259f21
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri Oct 13 17:18:10 2023 +0300

    fix getActualWindowsVersion()

commit 7425ee0
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri Oct 13 15:53:34 2023 +0300

    fix tests

commit 1550322
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri Oct 13 15:41:23 2023 +0300

    update changelog

commit cf480b3
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri Oct 13 15:41:07 2023 +0300

    add tests

commit 470a9dd
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri Oct 13 15:40:40 2023 +0300

    sent system_version during issues reporting

commit d0c7be6
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri Oct 13 15:40:02 2023 +0300

    update ua-parser-js

commit 5d3835f
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri Oct 13 15:35:58 2023 +0300

    update eslint max-len
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavaleleka slavaleleka

Labels
Feature Request Priority: P4 Resolution: Fixed Status: Closed Version: AdGuard v4.2.x (patch 2)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Alex-302 @adguard-bot @slavaleleka