Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable browser console scriptlet logging if Filtering log is closed #2584

Closed
Steven-DD opened this issue Nov 7, 2023 · 4 comments
Closed

Disable browser console scriptlet logging if Filtering log is closed #2584

Steven-DD opened this issue Nov 7, 2023 · 4 comments
Assignees
@slavaleleka
Labels
Bug Priority: P3 Resolution: Fixed Status: Resolved Version: AdGuard v4.2.x (patch 4)

Comments

@Steven-DD
Copy link

AdGuard Extension version

4.2.209

Browser version

Microsoft Edge 119.0.2151.44

OS version

Windows 11

What filters do you have enabled?

AdGuard Base filter, AdGuard Chinese filter, AdGuard Japanese filter, AdGuard Russian filter, AdGuard Tracking Protection filter, AdGuard URL Tracking filter, EasyList, EasyList China, EasyList Italy, Liste AR

What Stealth Mode options do you have enabled?

Block trackers, Remove tracking parameters, Hide your search queries, Send websites signals not to track you, Self-destruction of third-party cookies, Hide Referrer from third parties, Remove X-Client-Data header, Disable WebRTC

Issue Details

3 errors in the console when loading any page while AdGuard is enabled.

Expected Behavior

No error in the console.

Screenshots

Screenshot 1:

image

Additional Information

#2105

I noticed a related issue mentioned within this issue as well, and now it's come up again
@Steven-DD Steven-DD added the Bug label Nov 7, 2023
@maximtop
Copy link
Contributor

maximtop commented Nov 7, 2023

Hi, @Steven-DD
Are these logs visible if you close the filtering log window?

@Steven-DD
Copy link
Author

Hi, @Steven-DD Are these logs visible if you close the filtering log window?

Yes, whenever I open the developer tools and refresh the page, it appears in my log no matter what

@adguard-bot adguard-bot assigned maximtop and unassigned Birbber Nov 8, 2023
@maximtop
Copy link
Contributor

maximtop commented Nov 8, 2023

It seems that there is a bug.
Just wanted to clarify, is this option enabled at you?
image

If yes, then disable it, and reload extension (or browser), it should help.
This option shouldn't be responsible for making work of scriptlets more verbose. It should be verbose only if filtering log is open.

@adguard-bot adguard-bot changed the title scriptlet('set-constant', 'Document.prototype.browsingTopics', 'undefined') trace start Enable scriptlet logging based on filter log status Nov 8, 2023
@Steven-DD
Copy link
Author

It seems that there is a bug. Just wanted to clarify, is this option enabled at you? image

If yes, then disable it, and reload extension (or browser), it should help. This option shouldn't be responsible for making work of scriptlets more verbose. It should be verbose only if filtering log is open.

Yes, I've closed it now and will open it again when the bug is fixed. thank you!

@adguard-bot adguard-bot changed the title Enable scriptlet logging based on filter log status Disable browser console scriptlet logging if Filtering log is closed Nov 23, 2023
adguard pushed a commit to AdguardTeam/tsurlfilter that referenced this issue Nov 30, 2023
@slavaleleka
add settings.debugScriptlets. AG-27413
3d6c256 
AdguardTeam/AdguardBrowserExtension#2584

Squashed commit of the following:

commit d32feec
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Thu Nov 30 12:55:45 2023 +0200

    no extra settings.debugScriptlets checking

commit d5871d3
Author: Vladimir Zhelvis <v.zhelvis@adguard.com>
Date:   Thu Nov 30 13:46:22 2023 +0300

    add default value for debugScriptlets by zod

commit b949ebe
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed Nov 29 19:54:17 2023 +0200

    fix changelog

commit 12ca926
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed Nov 29 14:26:14 2023 +0200

    fix examples packages

commit 8690c50
Merge: 4a92c61 8d02bf8
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed Nov 29 14:24:56 2023 +0200

    merge master into the branch, resolve conflicts

commit 4a92c61
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue Nov 28 12:26:34 2023 +0200

    fix readme

commit 42a8fb9
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue Nov 28 12:25:15 2023 +0200

    update changelog

commit f9a2348
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Nov 27 15:36:49 2023 +0200

    fix naming

commit cc32398
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri Nov 24 13:23:11 2023 +0200

    fix changelog

commit 24a8bda
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri Nov 24 13:16:34 2023 +0200

    add settings.verboseScriptletsLogging

commit 229e6b5
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri Nov 24 13:15:35 2023 +0200

    update examples
adguard pushed a commit that referenced this issue Dec 1, 2023
@slavaleleka
log scriptlet to browser console only if filtering log is opened. #2584…
fb1df0a 
… AG-27413

Squashed commit of the following:

commit 689db87
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri Dec 1 11:48:09 2023 +0200

    fix tests

commit 1d0dbee
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Thu Nov 30 20:33:17 2023 +0200

    fix prop name

commit 999055d
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Thu Nov 30 20:29:39 2023 +0200

    update deps

commit 0d9d5c0
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Thu Nov 30 20:29:19 2023 +0200

    update changelog

commit 1f6998f
Merge: ea99ab2 5d3f7d5
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Thu Nov 30 20:27:37 2023 +0200

    merge master into the branch, resolve conflicts

commit ea99ab2
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Nov 27 15:37:18 2023 +0200

    fix naming

commit 902976b
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri Nov 24 13:25:39 2023 +0200

    update changelog

commit f6850b1
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri Nov 24 13:24:18 2023 +0200

    log scriptlet to browser console only if filtering log is opened
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavaleleka slavaleleka

Labels
Bug Priority: P3 Resolution: Fixed Status: Resolved Version: AdGuard v4.2.x (patch 4)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@maximtop @adguard-bot @slavaleleka @Steven-DD @stanislav-atr @Birbber @alexx7311