Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken patch updates occur when activating a group of filters #2714

Closed
105th opened this issue Feb 13, 2024 · 0 comments
Closed

Broken patch updates occur when activating a group of filters #2714

105th opened this issue Feb 13, 2024 · 0 comments
Assignees
@105th
Labels
Bug Priority: P3 Resolution: Fixed Status: Closed Version: AdGuard v4.3.x patch 3

Comments

@105th
Copy link
Member

105th commented Feb 13, 2024 •
edited

AdGuard Extension version

4.3.18 dev

Browser version

Chrome 121

OS version

macOS 12.5

What filters do you have enabled?

No filters

What Stealth Mode options do you have enabled?

No response

Issue Details

After installing the extension, if you activate filters by toggling a group of filters, the extension will not install the freshest filters, but instead filters from the built-in set. In this case, these filters may have broken patches updates until they are fully re-downloaded (within 5 days, which is the lifespan of a filter) because filters from the built-in set contain links to patches that may have already been deleted (we delete patches after 1 week of creation if they are not the last available patch).

Expected Behavior

We expect the same behavior as when directly toggling a filter - the extension will download the latest filter from the remote source.

Screenshots

Additional Information

No response
@105th 105th added the Bug label Feb 13, 2024
adguard pushed a commit that referenced this issue Mar 29, 2024
@105th @slavaleleka
update recommended filters on enabling group of filters. #2714 AG-30391
07b76a8 
Squashed commit of the following:

commit 96f9504
Merge: 2e9ecb0 6e9815d
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date:   Fri Mar 29 19:41:07 2024 +0300

    Merge branch 'master' into fix/AG-30391

commit 2e9ecb0
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date:   Fri Mar 29 19:04:38 2024 +0300

    renaming

commit d827a66
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date:   Fri Mar 29 17:42:50 2024 +0300

    add comments

commit aa9f4da
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date:   Fri Mar 29 17:41:42 2024 +0300

    fix tests

commit edefa31
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date:   Fri Mar 29 17:39:05 2024 +0300

    fix webpack variable

commit 93d32c4
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date:   Fri Mar 29 17:30:10 2024 +0300

    fixed tsconfig

commit a41119c
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date:   Fri Mar 29 17:20:23 2024 +0300

    fixes

commit 6da40c3
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date:   Thu Mar 28 14:22:49 2024 +0300

    fixes

commit 7df6131
Merge: 45587cf c67ce8b
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date:   Wed Mar 27 18:19:33 2024 +0300

    Merge branch 'master' into fix/AG-30391

commit 45587cf
Merge: 9c55479 800257c
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date:   Mon Mar 4 16:28:44 2024 +0300

    Merge branch 'master' into fix/AG-30391

commit 9c55479
Merge: df2e703 e2674a0
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date:   Mon Feb 26 13:46:23 2024 +0300

    Merge branch 'master' into fix/AG-30391

commit df2e703
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date:   Mon Feb 26 13:42:37 2024 +0300

    changes

commit 3deb585
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date:   Wed Feb 21 18:27:55 2024 +0300

    AG-30391: update recommended filters on enabling group of filters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@105th 105th

Labels
Bug Priority: P3 Resolution: Fixed Status: Closed Version: AdGuard v4.3.x patch 3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@105th @adguard-bot