Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Firefox for Android] Fix custom filter adding modal #2715

Closed
VladisLoveZh opened this issue Feb 14, 2024 · 1 comment
Closed

[Firefox for Android] Fix custom filter adding modal #2715

VladisLoveZh opened this issue Feb 14, 2024 · 1 comment
Assignees
@slavaleleka
Labels
Bug Priority: P2 Resolution: Fixed Status: Closed Version: AdGuard v4.3.x

Comments

@VladisLoveZh
Copy link

VladisLoveZh commented Feb 14, 2024 •
edited

AdGuard Extension version

4.3.12

Browser version

Firefox 121.0.1.

OS version

Android 10\ EMUI 12.0.0

What filters do you have enabled?

AdGuard Base filter

What Stealth Mode options do you have enabled?

Block trackers

Issue Details

Current layout in 'Filters'>'Custom'>‘add custom filter' in AdGuard Browser extension for Android' does not fit a screen in vertical mode.
’Trusted' check-box can't be seen unless in tablet mode

Expected Behavior

A correct layout thus all elements fits a screen as it should be.

Screenshots

Screenshot 1:

image

image
image

Additional Information

No response
@slavaleleka slavaleleka changed the title Improve AdGuard Extension layout [Firefox for Android] Fix custom filter adding modal Feb 14, 2024
@slavaleleka
Copy link
Contributor

duplicate: #2697

@adguard-bot adguard-bot assigned slavaleleka and unassigned maximtop Feb 16, 2024
adguard pushed a commit that referenced this issue Feb 20, 2024
@slavaleleka @maximtop
AG-30432 Fix custom filter adding modal. #2715 #2697
0679ce3 
Merge in EXTENSIONS/browser-extension from fix/AG-30432 to master

Squashed commit of the following:

commit 79de016
Merge: d297716 15bab4d
Author: Maxim Topciu <mtopciu@adguard.com>
Date:   Tue Feb 20 11:59:26 2024 +0200

    Merge branch 'master' into fix/AG-30432

commit d297716
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Feb 19 19:05:59 2024 +0200

    update changelog

commit cdc6d0a
Merge: 973e1c9 1b953d4
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Feb 19 19:05:12 2024 +0200

    Merge branch 'master' into fix/AG-30432

commit 973e1c9
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Feb 19 16:11:29 2024 +0200

    fix long custom filter title mobile style

commit e56d053
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Feb 19 15:58:06 2024 +0200

    fix AddCustomModal mobile style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavaleleka slavaleleka

Labels
Bug Priority: P2 Resolution: Fixed Status: Closed Version: AdGuard v4.3.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@maximtop @adguard-bot @slavaleleka @VladisLoveZh